From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92CC3C2D0DA for ; Wed, 25 Dec 2019 18:01:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F06D2067D for ; Wed, 25 Dec 2019 18:01:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577296909; bh=fLo9yHm/1JDoiQpRCA3Ae/AFF8TZu1tB58hdb1Fg7L4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=J3K8D7wXRBQJv30o+ZY5B+yWOWUj0oRgjW34MAWlx1bue0ao6DDzJLZfrkTL+woQw wjF5l3BdQcFHwryjaQOm0eMzOdDykOAWSVQOI9XX9xcwmlv9uGqDyFbaJcEvQzViaq jps7sWd0AgVqtwFVH4LTwdSlmiPCLCQw3lDa505o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726688AbfLYSBs (ORCPT ); Wed, 25 Dec 2019 13:01:48 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:56930 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbfLYSBr (ORCPT ); Wed, 25 Dec 2019 13:01:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Bq+UAHBLC8Yr9R0oLnqOKgljdZDdLqNGM6yBAh/5KII=; b=G5VKURfpViKG43vYhpo+eMr1e Z5LBDMi61V+PSTSnYgw2bNDEb5B5aUFFK6mhH/oo4OYqVzhTReT5TK2Z0EEiOHlO8fmoy1wmkZKfE M9DG6tdAaLXtDLm1ttVb0dqM5SZndP1vi1/ueBizRHUALU7HOKhPjk42cb3dd8XIEZxvo=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ikAyc-0001lO-HO; Wed, 25 Dec 2019 18:01:42 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 0D103D01A24; Wed, 25 Dec 2019 18:01:42 +0000 (GMT) Date: Wed, 25 Dec 2019 18:01:42 +0000 From: Mark Brown To: Kunihiko Hayashi Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Keiji Hayashibara , Masami Hiramatsu , Jassi Brar Subject: Re: [PATCH 4/5] spi: uniphier: Add SPI_LOOP to the capabilities Message-ID: <20191225180142.GD27497@sirena.org.uk> References: <1577149107-30670-1-git-send-email-hayashi.kunihiko@socionext.com> <1577149107-30670-5-git-send-email-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fOHHtNG4YXGJ0yqR" Content-Disposition: inline In-Reply-To: <1577149107-30670-5-git-send-email-hayashi.kunihiko@socionext.com> X-Cookie: I have many CHARTS and DIAGRAMS.. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fOHHtNG4YXGJ0yqR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 24, 2019 at 09:58:26AM +0900, Kunihiko Hayashi wrote: > Add SPI_LOOP to the capabilities to support loopback mode. > master->min_speed_hz = DIV_ROUND_UP(clk_rate, SSI_MAX_CLK_DIVIDER); > - master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LSB_FIRST; > + master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LSB_FIRST | > + SPI_LOOP; I'd expect to see a matching change that configures the hardware in loopback mode when the driver is in SPI_MODE? There's nothing in the existing driver. --fOHHtNG4YXGJ0yqR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4DpAUACgkQJNaLcl1U h9DGCwf8CErpoN6/aSizdxhROvbaxbMpt+6Wh6FxMDWHCl0b/S5wOEioBxEI6mnD 8xn4n0sNUZ9qnymFxuGoDrNN/qNl3UnJ9QyjxRCNg6fC6PI10I+SfzIZwe9BFDs5 RrDvozuG4OGgJbuE5BWHtaBTVP2afnzeFla+yszRxI7/j7Urg1Qlm7wUZjueXRd3 ifEjUTZNjmH3nx8+CV8WiiP0KFlzgQM/r0Gcjoj8NwW8UZj7Kepxg+XUs6vrOvwv 0i2iZwE/zFSKnDav0Whjjstv9HDwO17W1swi6bQbZanUkjzghYSLqdGOQm7vqB2r aVLi2EgBy54qeK1Zg5zKZ56TK8PexQ== =XK8L -----END PGP SIGNATURE----- --fOHHtNG4YXGJ0yqR--