From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73025C2D0C3 for ; Tue, 31 Dec 2019 00:29:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34560206CB for ; Tue, 31 Dec 2019 00:29:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577752173; bh=NjDyBj0VsqIxWyVqW+2dH9nRDhHyqeGwr1C+KeBjwZM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=M49r91Nvmu5Ltyr9t2BoB7FoDF0WrawYiMNheBOGfNvkR9+yxhXNtoeftJQSV75tT vbIe4bntG3JCQ0161XxdnTCCSjPdN7YI1Vd484Sw2YJEgb930MXsPDMX8zcRLoO8Z6 yHZ2Q2JyPX9Ay/9nV8FZtqC1Wz5HgcEvdmG0//mA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727807AbfLaA3c (ORCPT ); Mon, 30 Dec 2019 19:29:32 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:44134 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727750AbfLaA3b (ORCPT ); Mon, 30 Dec 2019 19:29:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=E2CRVJ0pla31OGboSymJBtJ7FSxHvmOY1w9JQQvCD/A=; b=GrnftHYLdETCv0Vpbc20gNKrT /9Sz3zOodG517fi/mF0KZxhh41t7FO7B809arEewV5h72lnVOgkPVR6GiH9act/hzi/JQtJ/OOQTj BKqkIq3O1ZbRvXunl0PS+sBESQLSd9cYc37b9FCQbpHUvtGmeVZdKsC5HebVUVCGIF+lk=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1im5Pd-0002nL-4G; Tue, 31 Dec 2019 00:29:29 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 87AD4D01A22; Tue, 31 Dec 2019 00:29:28 +0000 (GMT) Date: Tue, 31 Dec 2019 00:29:28 +0000 From: Mark Brown To: "wuxu.wu" Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, hushiyuan@huawei.com Subject: Re: [PATCH] spi: spi-dw: Add lock protect dw_spi rx/tx to prevent concurrent calls Message-ID: <20191231002928.GD3897@sirena.org.uk> References: <1577418669-34821-1-git-send-email-wuxu.wu@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iVCmgExH7+hIHJ1A" Content-Disposition: inline In-Reply-To: <1577418669-34821-1-git-send-email-wuxu.wu@huawei.com> X-Cookie: Programming is an unnatural act. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --iVCmgExH7+hIHJ1A Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 27, 2019 at 11:51:09AM +0800, wuxu.wu wrote: > static void dw_writer(struct dw_spi *dws) > { > - u32 max = tx_max(dws); > + u32 max > u16 txw = 0; This is going to break the build, there's a missing ; in the declaration of max. Otherwise this looks good. --iVCmgExH7+hIHJ1A Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4KlmcACgkQJNaLcl1U h9AA4Qf8DzOXFKYiWrGAwiKjNf1jfbj33s54tU8nmpfWwnaLfIgpqwSj0fTRnfwy tznV4UozcwcguyMAsbl4vn5Q0OrJOQfeLhwGdVBKXkJYOJLI40cgn0MFC6Ts4Ux3 il8MXI4Y93xXZ0OJh2BoW+j1MGNsCmAJ8PqtWiGr7yNygcp8aNmyytjXGbuBVooe aiKeSt2yCDXUgWkkPS5CEcuLFmjodgumOlHravhrdDpRcAUR00YuTPCooZ28AMpx kq+DAG4w0CcSyOsZcm0+ZJjIyO1DY5BYbNlb4TJJNPYQ6wNBi/3buiDZXfeBlGIN DwRokHH0vSzHS75GN7ha/Shm8Bq0WQ== =UER1 -----END PGP SIGNATURE----- --iVCmgExH7+hIHJ1A--