From: Andrew Morton <akpm@linux-foundation.org>
To: Gang He <GHe@suse.com>
Cc: "mark@fasheh.com" <mark@fasheh.com>,
"jlbec@evilplan.org" <jlbec@evilplan.org>,
"joseph.qi@linux.alibaba.com" <joseph.qi@linux.alibaba.com>,
Masahiro Yamada <masahiroy@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>
Subject: Re: [PATCH] ocfs2: make local header paths relative to C files
Date: Tue, 31 Dec 2019 14:33:31 -0800 [thread overview]
Message-ID: <20191231143331.9b77ee5709f2662c54d76a51@linux-foundation.org> (raw)
In-Reply-To: <20191227022950.14804-1-ghe@suse.com>
On Fri, 27 Dec 2019 02:30:15 +0000 Gang He <GHe@suse.com> wrote:
> From: Masahiro Yamada <masahiroy@kernel.org>
>
> Gang He reports the failure of building fs/ocfs2/ as an external module
> of the kernel installed on the system:
>
> $ cd fs/ocfs2
> $ make -C /lib/modules/`uname -r`/build M=`pwd` modules
>
> If you want to make it work reliably, I'd recommend to remove ccflags-y
> from the Makefiles, and to make header paths relative to the C files.
> I think this is the correct usage of the #include "..." directive.
>
> Reported-by: Gang He <ghe@suse.com>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> Reviewed-by: Gang He <ghe@suse.com>
Your signed-off-by should appear here, since you were on the patch
delivery path. I have made that change, OK?
prev parent reply other threads:[~2019-12-31 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 2:30 Gang He
2019-12-31 22:33 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191231143331.9b77ee5709f2662c54d76a51@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=GHe@suse.com \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=masahiroy@kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®