From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Dong Aisheng-B29396 <B29396@freescale.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [alsa-devel] [PATCH 2/5] ASoC: mxs: add .owner to struct snd_soc_card
Date: Fri, 9 Dec 2011 15:36:06 +0100 [thread overview]
Message-ID: <20194.7382.414612.182139@ipc1.ka-ro> (raw)
In-Reply-To: <20111209141203.GH3327@pengutronix.de>
Hi,
Wolfram Sang writes:
> On Fri, Dec 09, 2011 at 02:38:09PM +0100, Lothar Waßmann wrote:
> > This will prevent the module from being removed from underneath its
> > users
> >
> > Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
>
> I can't find any other instance setting owner in snd_soc_card?
>
Then that other uses are most probably faulty too.
You can easily test it by loading all necessary sound modules,
starting some application that uses the sound device (e.g. alsamixer)
and then removing the snd-soc-mxs-sgtl5000 module.
Without the patch the removal will succeed crashing the
application. With this patch the refcount of the module will be
> 0 as long as an application is using it, preventing the
removal.
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________
next prev parent reply other threads:[~2011-12-09 14:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 13:38 [PATCH 0/5] ASoC: mxs: Several cleanups and bugfixes for the MXS sound driver Lothar Waßmann
2011-12-09 13:38 ` [PATCH 1/5] ASoC: mxs: General cleanups Lothar Waßmann
2011-12-09 13:38 ` [PATCH 2/5] ASoC: mxs: add .owner to struct snd_soc_card Lothar Waßmann
2011-12-09 13:38 ` [PATCH 3/5] ASoC: mxs: Export symbols 'mxs_saif_put_mclk()' and 'mxs_saif_get_mclk()' Lothar Waßmann
2011-12-09 13:38 ` [PATCH 4/5] ASoC: mxs: Add missing MODULE_LICENSE("GPL") Lothar Waßmann
2011-12-09 13:38 ` [PATCH 5/5] ASoC: mxs: Add appropriate MODULE_ALIAS() Lothar Waßmann
2011-12-09 14:17 ` [alsa-devel] " Wolfram Sang
2011-12-11 2:59 ` Mark Brown
2011-12-09 14:17 ` [PATCH 4/5] ASoC: mxs: Add missing MODULE_LICENSE("GPL") Wolfram Sang
2011-12-11 2:59 ` Mark Brown
2011-12-09 14:15 ` [alsa-devel] [PATCH 3/5] ASoC: mxs: Export symbols 'mxs_saif_put_mclk()' and 'mxs_saif_get_mclk()' Wolfram Sang
2011-12-11 2:55 ` Mark Brown
2011-12-09 14:12 ` [alsa-devel] [PATCH 2/5] ASoC: mxs: add .owner to struct snd_soc_card Wolfram Sang
2011-12-09 14:36 ` Lothar Waßmann [this message]
2011-12-11 2:53 ` Mark Brown
2011-12-12 9:10 ` Lothar Waßmann
2011-12-12 10:04 ` Mark Brown
2011-12-09 14:07 ` [PATCH 1/5] ASoC: mxs: General cleanups Wolfram Sang
2011-12-11 3:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20194.7382.414612.182139@ipc1.ka-ro \
--to=lw@karo-electronics.de \
--cc=B29396@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®