mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: olteanv@gmail.com
Cc: f.fainelli@gmail.com, vivien.didelot@gmail.com, andrew@lunn.ch,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] Improvements to the DSA deferred xmit
Date: Thu, 02 Jan 2020 13:49:52 -0800 (PST)	[thread overview]
Message-ID: <20200102.134952.739616655559887645.davem@davemloft.net> (raw)
In-Reply-To: <20191227014208.7189-1-olteanv@gmail.com>

From: Vladimir Oltean <olteanv@gmail.com>
Date: Fri, 27 Dec 2019 03:42:06 +0200

> The DSA deferred xmit mechanism is currently used by a single driver
> (sja1105) because the transmission of some operations requires SPI
> access in the fastpath.
> 
> This 2-patch series makes this mechanism better for everybody:
> 
> - For those who don't use it, thanks to one less assignment in the
>   hotpath
> - For those who do, by making its scheduling more amenable and moving it
>   outside the generic workqueue (since it still deals with packet
>   hotpath, after all)

Two comments about this patch series, I think it needs more work:

1) This adds the thread and the xmit queue but not code that actually
   uses it.  You really have to provide the support code in the driver
   at the same time you add the new facitlity so we can actually see
   how it'll be used.

2) Patch #1 talks about a tradeoff.  Replacing the CB initialization of
   the field skb_get().  But this skb_get() is an atomic operation and
   thus much more expensive for users of the deferred xmit scheme.

Thanks.

  parent reply	other threads:[~2020-01-02 21:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-27  1:42 Vladimir Oltean
2019-12-27  1:42 ` [PATCH net-next 1/2] net: dsa: Remove deferred_xmit from dsa_skb_cb Vladimir Oltean
2019-12-27  1:42 ` [PATCH net-next 2/2] net: dsa: Create a kernel thread for each port's deferred xmit work Vladimir Oltean
2020-01-02 21:49 ` David Miller [this message]
2020-01-02 22:47   ` [PATCH net-next 0/2] Improvements to the DSA deferred xmit Vladimir Oltean
2020-01-03 20:10     ` Florian Fainelli
2020-01-04  2:44       ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200102.134952.739616655559887645.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®