From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Vinod Koul <vkoul@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/7] dmaengine: tegra-apb: Prevent race conditions on channel's freeing
Date: Fri, 3 Jan 2020 09:16:04 +0100 [thread overview]
Message-ID: <20200103081604.GD14228@qmqm.qmqm.pl> (raw)
In-Reply-To: <4e1e4fef-f75c-f2e2-4d9e-29af69daf8db@gmail.com>
On Thu, Jan 02, 2020 at 06:09:45PM +0300, Dmitry Osipenko wrote:
> 30.12.2019 23:50, Michał Mirosław пишет:
> > On Mon, Dec 30, 2019 at 09:45:55PM +0100, Michał Mirosław wrote:
> >> On Sat, Dec 28, 2019 at 11:46:36PM +0300, Dmitry Osipenko wrote:
> >>> It's unsafe to check the channel's "busy" state without taking a lock,
> >>> it is also unsafe to assume that tasklet isn't in-fly.
> >>
> >> 'in-flight'. Also, the patch seems to have two independent bug-fixes
> >> in it. Second one doesn't look right, at least not without an explanation.
> >>
> >> First:
> >>
> >>> - if (tdc->busy)
> >>> - tegra_dma_terminate_all(dc);
> >>> + tegra_dma_terminate_all(dc);
> >>
> >> Second:
> >>
> >>> + tasklet_kill(&tdc->tasklet);
> >
> > BTW, maybe you can convert the code to threaded interrupt handler and
> > just get rid of the tasklet instead of fixing it?
>
> This shouldn't bring much benefit because the the code's logic won't be
> changed since we will still have to use the threaded ISR part as the
> bottom-half and then IRQ API doesn't provide a nice way to synchronize
> interrupt's execution, while tasklet_kill() is a nice way to sync it.
What about synchronize_irq()?
BTW, does tegra_dma_terminate_all() prevent further interrupts that might
cause the tasklet to be scheduled again?
Best Regards,
Michał Mirosław
next prev parent reply other threads:[~2020-01-03 8:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-28 20:46 [PATCH v1 0/7] NVIDIA Tegra APB DMA driver fixes and improvements Dmitry Osipenko
2019-12-28 20:46 ` [PATCH v1 1/7] dmaengine: tegra-apb: Fix use-after-free Dmitry Osipenko
2019-12-28 20:46 ` [PATCH v1 2/7] dmaengine: tegra-apb: Implement synchronization callback Dmitry Osipenko
2019-12-28 20:46 ` [PATCH v1 3/7] dmaengine: tegra-apb: Prevent race conditions on channel's freeing Dmitry Osipenko
2019-12-30 20:45 ` Michał Mirosław
2019-12-30 20:50 ` Michał Mirosław
2020-01-02 15:09 ` Dmitry Osipenko
2020-01-03 8:16 ` Michał Mirosław [this message]
2020-01-04 0:27 ` Dmitry Osipenko
2020-01-02 15:03 ` Dmitry Osipenko
2019-12-28 20:46 ` [PATCH v1 4/7] dmaengine: tegra-apb: Prevent race conditions of tasklet vs free list Dmitry Osipenko
2019-12-28 20:46 ` [PATCH v1 5/7] dmaengine: tegra-apb: Use devm_platform_ioremap_resource Dmitry Osipenko
2019-12-28 20:46 ` [PATCH v1 6/7] dmaengine: tegra-apb: Use devm_request_irq Dmitry Osipenko
2019-12-28 20:46 ` [PATCH v1 7/7] dmaengine: tegra-apb: Fix coding style problems Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103081604.GD14228@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=dan.j.williams@intel.com \
--cc=digetx@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®