From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4489C3276F for ; Sat, 4 Jan 2020 11:46:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91BD224649 for ; Sat, 4 Jan 2020 11:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578138369; bh=BIfs1NixzYretDBMD+eLD0lOwz5l1r8LwnPk2qddhaM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Ku5PF4ujSAPYxh5829dLfWGFLFqzBjnbNxUjjb0XFEFIpjNyDUMbq5fRUJnifkcl5 FK5qksAFc03b3nnch7rtT2TEEh0w/L7m1GhcY3S1f34le+UVC4oCp5xoE21v+vhOpb O0pXzDsYoqPSB/Ld5oM1JI0sO+N0MxSW8lOZyEJQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726061AbgADLqG (ORCPT ); Sat, 4 Jan 2020 06:46:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:38268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbgADLqG (ORCPT ); Sat, 4 Jan 2020 06:46:06 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5EF09215A4; Sat, 4 Jan 2020 11:46:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578138365; bh=BIfs1NixzYretDBMD+eLD0lOwz5l1r8LwnPk2qddhaM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aSo0ppJF1kT3u0Rw9MZLTSYurBo81qyT++5jI8nw7Poi9LvhHpgvbcY/oRV+ka6n4 034dzlZU0/ow4g85zwAa6BVOGB+fkqxCaN3RVY4kRmP0prsNKO1TekeFRDt27ihEeo +dv7y9u6dezO0LUybYGdVrDhtuv3GcwNaUYTH9qY= Date: Sat, 4 Jan 2020 12:46:03 +0100 From: "gregkh@linuxfoundation.org" To: atmgnd Cc: Alan Stern , Randy Dunlap , "linux-kernel@vger.kernel.org" , USB list Subject: Re: [PATCH] usb: missing parentheses in USE_NEW_SCHEME Message-ID: <20200104114603.GB1288021@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 04, 2020 at 11:02:01AM +0000, atmgnd wrote: > accroding to bd0e6c9#diff-28615d62e1250eadc353d804f49bc6d6, will try old enumeration > scheme first for high speed devices. for example, when a high speed device pluged in, > line 2720 should expand to 0 at the first time. USE_NEW_SCHEME(0, 0 || 0 || 1) === 0. > but it wrongly expand to 1(alway expand to 1 for high speed device), and change > USE_NEW_SCHEME to USE_NEW_SCHEME((i) % 2 == (int)(scheme)) may be better ? > > Acked-by: Alan Stern > Signed-off-by: Qi Zhou > --- > drivers/usb/core/hub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c > index f229ad6952c0..7d17deca7021 100644 > --- a/drivers/usb/core/hub.c > +++ b/drivers/usb/core/hub.c > @@ -2692,7 +2692,7 @@ static unsigned hub_is_wusb(struct usb_hub *hub) > #define SET_ADDRESS_TRIES 2 > #define GET_DESCRIPTOR_TRIES 2 > #define SET_CONFIG_TRIES (2 * (use_both_schemes + 1)) > -#define USE_NEW_SCHEME(i, scheme) ((i) / 2 == (int)scheme) > +#define USE_NEW_SCHEME(i, scheme) ((i) / 2 == (int)(scheme)) > > #define HUB_ROOT_RESET_TIME 60 /* times are in msec */ > #define HUB_SHORT_RESET_TIME 10 > -- > 2.17.1 > > Much better, but your From: name does not match your signed-off-by name :(