From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E6ACC32771 for ; Mon, 6 Jan 2020 08:59:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A241215A4 for ; Mon, 6 Jan 2020 08:59:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="Y6yD6Dl8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726411AbgAFI7q (ORCPT ); Mon, 6 Jan 2020 03:59:46 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:32925 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726133AbgAFI7q (ORCPT ); Mon, 6 Jan 2020 03:59:46 -0500 Received: by mail-wm1-f67.google.com with SMTP id d139so11504785wmd.0 for ; Mon, 06 Jan 2020 00:59:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/ZwyOis6F3QKO9vpXF7tA9K3dMi7rhKdiD8Hhm+STvI=; b=Y6yD6Dl8fSrpCiMi6JFctDAcHcLCWwV4WbimfBvj3+DL9Ty8MfYj5w1Jus52QpCEJl nlmHxj+yyP4MtkOxKVVgDe7K2MPPf5cMrUjhsM8svB3s9M6RYkSINppYo2FslFGuSox8 fRb6bdg9iqcq0j5GEsidiFjyXNfdXtYqabeDILKYHaPmBhD9Ipydv3If5LV3nXeNKcdt EPO/FkJ9ZXJjNjxHdfr3Pz1/8pLLlOaGP+EuBz1Mv/SqE9k816wR/Ss6b7WH5sY734FS d3wOMe/FAYyhHeGbZ+9XsFeKMFPxdF9RJ42+wHli+mv5DlaM7u7YwKnLlejHmga0BPn8 Qf8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/ZwyOis6F3QKO9vpXF7tA9K3dMi7rhKdiD8Hhm+STvI=; b=FfXQvd2IzXW6blQ35mamd7bxih1RPVF6cZ+e5lJB18yYCMeX8g73vd4oRkHp21tWjG ZQdKFr73yVu5Mk2y2719NQpQKY0SEU64XQWcOp2mCWlaJh7iQyE+jiVsef6nUEjka92F XhNMdgSqseCQb4BXDyVUnFRMingA/WN3X4tghnicpfPFhGeFQdkPAFSrHSt6nKZ5gfBP BbLAEGozFfWmnfH+c8CqbpXKjyFlw/CCRIwQVHpMV7hmOY0Vot+UhQbsyfnGX9QNbYJn 8KDNct7kX2wmw/b31Nz1JsB+MWb2Ogpmqe7Li+BWmmmF+z6KdsT44eRaZrUxm6sJC5g7 wr+w== X-Gm-Message-State: APjAAAU2wu/u+SXNh1M0KHu8xhbzi1TT+djCZej0Ffc4XCnd4DnP0bs1 8Oi/kmad5QGSwr6YvUnfCPW+pA== X-Google-Smtp-Source: APXvYqxF9x2VCzl/gJXkRc4d1WJjn/hIPNpdwO3oQ7KKNlfk2KXb1uw38kE6ewg/kcMvECWhpHrbPA== X-Received: by 2002:a05:600c:2551:: with SMTP id e17mr2841233wma.26.1578301184153; Mon, 06 Jan 2020 00:59:44 -0800 (PST) Received: from netronome.com ([2001:982:756:703:d63d:7eff:fe99:ac9d]) by smtp.gmail.com with ESMTPSA id x11sm73880628wre.68.2020.01.06.00.59.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2020 00:59:44 -0800 (PST) Date: Mon, 6 Jan 2020 09:59:43 +0100 From: Simon Horman To: Christophe JAILLET Cc: pablo@netfilter.org, laforge@gnumonks.org, davem@davemloft.net, osmocom-net-gprs@lists.osmocom.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] gtp: simplify error handling code in 'gtp_encap_enable()' Message-ID: <20200106085943.GB10460@netronome.com> References: <20200105173607.5456-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200105173607.5456-1-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 05, 2020 at 06:36:07PM +0100, Christophe JAILLET wrote: > 'gtp_encap_disable_sock(sk)' handles the case where sk is NULL, so there > is no need to test it before calling the function. > > This saves a few line of code. > > Signed-off-by: Christophe JAILLET Reviewed-by: Simon Horman