From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71164C33C9B for ; Mon, 6 Jan 2020 23:05:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 487D52075A for ; Mon, 6 Jan 2020 23:05:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G4Y7lI8p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727233AbgAFXFM (ORCPT ); Mon, 6 Jan 2020 18:05:12 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:46942 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726735AbgAFXFM (ORCPT ); Mon, 6 Jan 2020 18:05:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578351910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5FUwndBIrFS376iq6UZxigDCdyXQx4W62Bo2bpWtvvU=; b=G4Y7lI8pUX8BE2TKDRr4TeCkJFEjUL58XMd+os1uJcyMyrO4L9j5epDHJkNoIciRxxSMEv D5DLV44uVLbH+1MZNd/w2z2cBX/ZpsaxdWVHAdt6OW04B3uv7L+N9kBP1kuhYzeWf4sWjA zFzVyMiNW9hDa/daa+JD2qOr6klFGC8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-190-iBhoNrFePfelJiDunoLm6A-1; Mon, 06 Jan 2020 18:05:08 -0500 X-MC-Unique: iBhoNrFePfelJiDunoLm6A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 834CB1800D4E; Mon, 6 Jan 2020 23:05:06 +0000 (UTC) Received: from w520.home (ovpn-116-26.phx2.redhat.com [10.3.116.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 257F65D9D6; Mon, 6 Jan 2020 23:05:05 +0000 (UTC) Date: Mon, 6 Jan 2020 16:05:05 -0700 From: Alex Williamson To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, Cornelia Huck , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] vfio: vfio_pci_nvlink2: use mmgrab Message-ID: <20200106160505.2f962d38@w520.home> In-Reply-To: <1577634178-22530-3-git-send-email-Julia.Lawall@inria.fr> References: <1577634178-22530-1-git-send-email-Julia.Lawall@inria.fr> <1577634178-22530-3-git-send-email-Julia.Lawall@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 29 Dec 2019 16:42:56 +0100 Julia Lawall wrote: > Mmgrab was introduced in commit f1f1007644ff ("mm: add new mmgrab() > helper") and most of the kernel was updated to use it. Update a > remaining file. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > > @@ expression e; @@ > - atomic_inc(&e->mm_count); > + mmgrab(e); > > > Signed-off-by: Julia Lawall > > --- > drivers/vfio/pci/vfio_pci_nvlink2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci_nvlink2.c b/drivers/vfio/pci/vfio_pci_nvlink2.c > index f2983f0f84be..43df10af7f66 100644 > --- a/drivers/vfio/pci/vfio_pci_nvlink2.c > +++ b/drivers/vfio/pci/vfio_pci_nvlink2.c > @@ -159,7 +159,7 @@ static int vfio_pci_nvgpu_mmap(struct vfio_pci_device *vdev, > data->useraddr = vma->vm_start; > data->mm = current->mm; > > - atomic_inc(&data->mm->mm_count); > + mmgrab(data->mm); > ret = (int) mm_iommu_newdev(data->mm, data->useraddr, > vma_pages(vma), data->gpu_hpa, &data->mem); > > Acked-by: Alex Williamson Thanks! I'm assuming these will be routed via janitors tree, please let me know if you intend me to grab these two vfio patches from the series. Thanks, Alex