From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F5EC33C8C for ; Mon, 6 Jan 2020 16:07:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E32B2467D for ; Mon, 6 Jan 2020 16:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578326872; bh=FujDq/kHrhJEWeENq9jN+oNiwsQo0/L2lnSlXsVYWsI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2pqMMCEGbx8X/xwfrwxE7+JskE8/2Br54kdXZ4uXPGVn+SHY3p4F8x/g3zrSUKjz9 OAP95nHt/Nb288j5x+rgbwhnUA3+mDRHG5GV2v3uS3rs6HSuEbtj8Ukd6u95N19SK+ s7ra75gK6saNl9W5LH+m5ndtbVUPaL3PR1n1eWTw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727139AbgAFQHv (ORCPT ); Mon, 6 Jan 2020 11:07:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:45746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727103AbgAFQHs (ORCPT ); Mon, 6 Jan 2020 11:07:48 -0500 Received: from quaco.ghostprotocols.net (unknown [179.97.35.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C893224676; Mon, 6 Jan 2020 16:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578326868; bh=FujDq/kHrhJEWeENq9jN+oNiwsQo0/L2lnSlXsVYWsI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SeTZ6zdo8NWw+0AjpqzNpm7Z5ktiVHBn1Yx9Y5gdHGxmmWBWpLa7WI726VKBSWR6J rqeq+0wJv2ao5mWMGZush3BrViRX3Gz99Dp4mrR5TRJYvu+LRO9jLXOP/Ke95jmbt/ /JvdoWhi83pKZWQxDB/N4gH/3MHwgSYaPrNTfbXU= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter Subject: [PATCH 09/20] perf hists browser: Restore ESC as "Zoom out" of DSO/thread/etc Date: Mon, 6 Jan 2020 13:06:54 -0300 Message-Id: <20200106160705.10899-10-acme@kernel.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200106160705.10899-1-acme@kernel.org> References: <20200106160705.10899-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnaldo Carvalho de Melo We need to set actions->ms.map since 599a2f38a989 ("perf hists browser: Check sort keys before hot key actions"), as in that patch we bail out if map is NULL. Reviewed-by: Jiri Olsa Cc: Adrian Hunter Cc: Namhyung Kim Fixes: 599a2f38a989 ("perf hists browser: Check sort keys before hot key actions") Link: https://lkml.kernel.org/n/tip-wp1ssoewy6zihwwexqpohv0j@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/browsers/hists.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index d4d3558fdef4..cfc6172ecab7 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -3062,6 +3062,7 @@ static int perf_evsel__hists_browse(struct evsel *evsel, int nr_events, continue; } + actions->ms.map = map; top = pstack__peek(browser->pstack); if (top == &browser->hists->dso_filter) { /* -- 2.21.1