From: Mark Brown <broonie@kernel.org>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: "dries.vanpuymbroeck@dekimo.com" <dries.vanpuymbroeck@dekimo.com>,
"anthony.derosa@syscall7.com" <anthony.derosa@syscall7.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Multiplex SPI Chip Selects
Date: Mon, 6 Jan 2020 22:51:38 +0000 [thread overview]
Message-ID: <20200106225138.GE6448@sirena.org.uk> (raw)
In-Reply-To: <2db6a1c2463ca5cf41795b5348e17cfbd7de5fe3.camel@alliedtelesis.co.nz>
[-- Attachment #1: Type: text/plain, Size: 1401 bytes --]
On Mon, Jan 06, 2020 at 10:44:15PM +0000, Chris Packham wrote:
> On Mon, 2020-01-06 at 08:27 -0500, Anthony DeRosa wrote:
As documented in submitting-patches.rst please send patches to the
maintainers for the code you would like to change. The normal kernel
workflow is that people apply patches from their inboxes, if they aren't
copied they are likely to not see the patch at all and it is much more
difficult to apply patches.
> > This proposed patch does exactly what I need to do:
> > https://patchwork.kernel.org/patch/2706151/, but I was wondering why
> > nothing like this already exists or why that patch had not been
> > included in the mainline kernel.
> I don't know why Dries' patch series didn't land. The reason my one
> didn't land was due to some implementation details and the ability to
> do something simpler with a fake gpio.
If you want me to review something you'l need to submit it; that patch
was from 2013 so predates me maintaining the subsystem so I've never
seen a copy.
My general instinct with this stuff is that it's likely to be more
sensible to describe this with GPIO chip selects, the state of
controller chip selects is such that a lot of devices use them anyway
even when the controller supports native chip selects as the controller
chip selects often suffer from unfortunate limitations that mean they're
not actually useful.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-01-06 22:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAB595VxuL+iOQD3Re1PbjP50GD51XuMML8_R6Ku2ywAAHcOcdw@mail.gmail.com>
[not found] ` <a0171241162171ffac6429d29edfaa83fbd9a2ba.camel@alliedtelesis.co.nz>
[not found] ` <CAB595VzfMRU4Pejuzi0jODvu9p_mh473-cdK92jxSxk3yPHtqw@mail.gmail.com>
2020-01-06 22:44 ` Chris Packham
2020-01-06 22:51 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106225138.GE6448@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=anthony.derosa@syscall7.com \
--cc=dries.vanpuymbroeck@dekimo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®