From: Chanwoo Choi <cw00.choi@samsung.com>
To: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: leonard.crestez@nxp.com, lukasz.luba@arm.com,
a.swigon@samsung.com, m.szyprowski@samsung.com,
enric.balletbo@collabora.com, hl@rock-chips.com,
digetx@gmail.com, bjorn.andersson@linaro.org,
jcrouse@codeaurora.org, cw00.choi@samsung.com,
chanwoo@kernel.org, myungjoo.ham@samsung.com,
kyungmin.park@samsung.com
Subject: [PATCH 1/2] PM / devfreq: Add debugfs support with devfreq_summary file
Date: Tue, 7 Jan 2020 18:05:18 +0900 [thread overview]
Message-ID: <20200107090519.3231-2-cw00.choi@samsung.com> (raw)
In-Reply-To: <20200107090519.3231-1-cw00.choi@samsung.com>
Add debugfs interface to provide debugging information of devfreq device.
It contains 'devfreq_summary' entry to show the summary of registered
devfreq devices as following and the additional debugfs file will be added.
- /sys/kernel/debug/devfreq/devfreq_summary
[Detailed description of each field of 'devfreq_summary' debugfs file]
- dev_name : Device name of h/w.
- dev : Device name made by devfreq core.
- parent_dev : If devfreq device uses the passive governor,
show parent devfreq device name.
- governor : Devfreq governor.
- polling_ms : If devfreq device uses the simple_ondemand governor,
polling_ms is necessary for the period. (unit: millisecond)
- cur_freq_hz : Current Frequency (unit: hz)
- old_freq_hz : Frequency before changing. (unit: hz)
- new_freq_hz : Frequency after changed. (unit: hz)
[For example on Exynos5422-based Odroid-XU3 board]
- In order to show the multiple governors on devfreq_summay result,
change the governor of devfreq0 from simple_ondemand to userspace.
$ cat /sys/kernel/debug/devfreq/devfreq_summary
dev_name dev parent_dev governor polling_ms cur_freq_hz min_freq_hz max_freq_hz
------------------------------ ---------- ---------- --------------- ---------- ------------ ------------ ------------
10c20000.memory-controller devfreq0 userspace 0 206000000 165000000 825000000
soc:bus_wcore devfreq1 simple_ondemand 50 532000000 88700000 532000000
soc:bus_noc devfreq2 devfreq1 passive 0 111000000 66600000 111000000
soc:bus_fsys_apb devfreq3 devfreq1 passive 0 222000000 111000000 222000000
soc:bus_fsys devfreq4 devfreq1 passive 0 200000000 75000000 200000000
soc:bus_fsys2 devfreq5 devfreq1 passive 0 200000000 75000000 200000000
soc:bus_mfc devfreq6 devfreq1 passive 0 333000000 83250000 333000000
soc:bus_gen devfreq7 devfreq1 passive 0 266000000 88700000 266000000
soc:bus_peri devfreq8 devfreq1 passive 0 66600000 66600000 66600000
soc:bus_g2d devfreq9 devfreq1 passive 0 0 83250000 333000000
soc:bus_g2d_acp devfreq10 devfreq1 passive 0 0 66500000 266000000
soc:bus_jpeg devfreq11 devfreq1 passive 0 0 75000000 300000000
soc:bus_jpeg_apb devfreq12 devfreq1 passive 0 0 83250000 166500000
soc:bus_disp1_fimd devfreq13 devfreq1 passive 0 0 120000000 200000000
soc:bus_disp1 devfreq14 devfreq1 passive 0 0 120000000 300000000
soc:bus_gscl_scaler devfreq15 devfreq1 passive 0 0 150000000 300000000
soc:bus_mscl devfreq16 devfreq1 passive 0 0 84000000 666000000
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
drivers/devfreq/devfreq.c | 80 +++++++++++++++++++++++++++++++++++++++
1 file changed, 80 insertions(+)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 254f11b31824..c7f5e4e06420 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -10,6 +10,7 @@
#include <linux/kernel.h>
#include <linux/kmod.h>
#include <linux/sched.h>
+#include <linux/debugfs.h>
#include <linux/errno.h>
#include <linux/err.h>
#include <linux/init.h>
@@ -33,6 +34,7 @@
#define HZ_PER_KHZ 1000
static struct class *devfreq_class;
+static struct dentry *devfreq_debugfs;
/*
* devfreq core provides delayed work based load monitoring helper
@@ -1717,6 +1719,74 @@ static struct attribute *devfreq_attrs[] = {
};
ATTRIBUTE_GROUPS(devfreq);
+/**
+ * devfreq_summary_show() - Show the summary of the registered devfreq devices
+ * via 'devfreq_summary' debugfs file.
+ */
+static int devfreq_summary_show(struct seq_file *s, void *data)
+{
+ struct devfreq *devfreq;
+ struct devfreq *p_devfreq = NULL;
+ unsigned long cur_freq, min_freq, max_freq;
+ unsigned int polling_ms;
+
+ seq_printf(s, "%-30s %-10s %-10s %-15s %-10s %-12s %-12s %-12s\n",
+ "dev_name",
+ "dev",
+ "parent_dev",
+ "governor",
+ "polling_ms",
+ "cur_freq_hz",
+ "min_freq_hz",
+ "max_freq_hz");
+ seq_printf(s, "%-30s %-10s %-10s %-15s %-10s %-12s %-12s %-12s\n",
+ "------------------------------",
+ "----------",
+ "----------",
+ "---------------",
+ "----------",
+ "------------",
+ "------------",
+ "------------");
+
+ mutex_lock(&devfreq_list_lock);
+
+ list_for_each_entry_reverse(devfreq, &devfreq_list, node) {
+#if IS_ENABLED(CONFIG_DEVFREQ_GOV_PASSIVE)
+ if (!strncmp(devfreq->governor_name, DEVFREQ_GOV_PASSIVE,
+ DEVFREQ_NAME_LEN)) {
+ struct devfreq_passive_data *data = devfreq->data;
+
+ if (data)
+ p_devfreq = data->parent;
+ } else {
+ p_devfreq = NULL;
+ }
+#endif
+ mutex_lock(&devfreq->lock);
+ cur_freq = devfreq->previous_freq,
+ get_freq_range(devfreq, &min_freq, &max_freq);
+ polling_ms = devfreq->profile->polling_ms,
+ mutex_unlock(&devfreq->lock);
+
+ seq_printf(s,
+ "%-30s %-10s %-10s %-15s %-10d %-12ld %-12ld %-12ld\n",
+ dev_name(devfreq->dev.parent),
+ dev_name(&devfreq->dev),
+ p_devfreq ? dev_name(&p_devfreq->dev) : "",
+ devfreq->governor_name,
+ polling_ms,
+ cur_freq,
+ min_freq,
+ max_freq);
+ }
+
+ mutex_unlock(&devfreq_list_lock);
+
+ return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(devfreq_summary);
+
static int __init devfreq_init(void)
{
devfreq_class = class_create(THIS_MODULE, "devfreq");
@@ -1733,6 +1803,16 @@ static int __init devfreq_init(void)
}
devfreq_class->dev_groups = devfreq_groups;
+ devfreq_debugfs = debugfs_create_dir("devfreq", NULL);
+ if (PTR_ERR(devfreq_debugfs) != -ENODEV && IS_ERR(devfreq_debugfs)) {
+ devfreq_debugfs = NULL;
+ pr_warn("%s: couldn't create debugfs dir\n", __FILE__);
+ } else {
+ debugfs_create_file("devfreq_summary", 0444,
+ devfreq_debugfs, NULL,
+ &devfreq_summary_fops);
+ }
+
return 0;
}
subsys_initcall(devfreq_init);
--
2.17.1
next prev parent reply other threads:[~2020-01-07 8:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200107085812epcas1p4eb4f51c2ade10db700fbfd62ab4779fb@epcas1p4.samsung.com>
2020-01-07 9:05 ` [PATCH 0/2] PM / devfreq: Add debugfs support Chanwoo Choi
[not found] ` <CGME20200107085812epcas1p12121f8ef6492ed78053dea4977216788@epcas1p1.samsung.com>
2020-01-07 9:05 ` Chanwoo Choi [this message]
2020-01-07 21:15 ` [PATCH 1/2] PM / devfreq: Add debugfs support with devfreq_summary file Bjorn Andersson
2020-01-08 7:56 ` Chanwoo Choi
2020-01-08 14:14 ` Dmitry Osipenko
2020-01-13 4:45 ` Chanwoo Choi
[not found] ` <CGME20200107085812epcas1p4670ae2265573d887aa75cab36c04b1ea@epcas1p4.samsung.com>
2020-01-07 9:05 ` [PATCH 2/2] PM / devfreq: Add devfreq_transitions debugfs file Chanwoo Choi
2020-01-07 21:31 ` Dmitry Osipenko
2020-01-08 10:56 ` Chanwoo Choi
2020-01-08 12:01 ` Chanwoo Choi
2020-01-08 14:23 ` Dmitry Osipenko
2020-01-09 0:44 ` Chanwoo Choi
2020-01-07 21:48 ` Bjorn Andersson
2020-01-08 14:20 ` Dmitry Osipenko
2020-01-08 15:44 ` Lukasz Luba
2020-01-09 10:45 ` Chanwoo Choi
2020-01-13 17:19 ` Leonard Crestez
2020-01-14 12:52 ` Lukasz Luba
2020-01-09 8:07 ` Chanwoo Choi
2020-01-09 17:21 ` Bjorn Andersson
2020-01-10 5:04 ` Chanwoo Choi
2020-01-10 6:56 ` Chanwoo Choi
2020-01-07 21:56 ` Dmitry Osipenko
2020-01-08 11:22 ` Chanwoo Choi
2020-01-08 11:51 ` Chanwoo Choi
2020-01-08 14:10 ` Dmitry Osipenko
2020-01-09 8:14 ` Chanwoo Choi
2020-01-10 8:56 ` Kamil Konieczny
2020-01-09 15:06 ` [PATCH 0/2] PM / devfreq: Add debugfs support Kamil Konieczny
2020-01-10 3:17 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107090519.3231-2-cw00.choi@samsung.com \
--to=cw00.choi@samsung.com \
--cc=a.swigon@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=chanwoo@kernel.org \
--cc=digetx@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=hl@rock-chips.com \
--cc=jcrouse@codeaurora.org \
--cc=kyungmin.park@samsung.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®