From: <patrice.chotard@st.com>
To: <robh+dt@kernel.org>, <mark.rutland@arm.com>,
<linux@armlinux.org.uk>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Cc: <patrice.chotard@st.com>
Subject: [PATCH 1/2] ARM: dts: stih410-b2260: Fix ethernet phy DT node
Date: Tue, 7 Jan 2020 13:38:27 +0100 [thread overview]
Message-ID: <20200107123828.6586-2-patrice.chotard@st.com> (raw)
In-Reply-To: <20200107123828.6586-1-patrice.chotard@st.com>
From: Patrice Chotard <patrice.chotard@st.com>
Since 'd3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms without PHY")'
we got the following kernel Oops :
Unable to handle kernel NULL pointer dereference at virtual address 00000260
pgd = (ptrval)
[00000260] *pgd=79a79831
Internal error: Oops: 17 [#1] SMP ARM
Modules linked in:
CPU: 0 PID: 201 Comm: ip Not tainted 5.5.0-rc5 #13
Hardware name: STi SoC with Flattened Device Tree
PC is at mdiobus_get_phy+0x4/0x20
LR is at stmmac_open+0x278/0xaa8
pc : [<c0a7e41c>] lr : [<c0b1755c>] psr: a0070013
sp : ed663930 ip : 00000000 fp : c110079c
r10: ed663d4c r9 : ed663d4c r8 : ee774028
r7 : ee22ad00 r6 : ee776000 r5 : 00000000 r4 : ee774000
r3 : ee775000 r2 : ca451a07 r1 : 00000098 r0 : 00000000
Flags: NzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none
Control: 10c5387d Table: 6d75404a DAC: 00000051
Process ip (pid: 201, stack limit = 0x(ptrval))
This is due to lack of mdio DT subnode, so add it.
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---
arch/arm/boot/dts/stih410-b2260.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/stih410-b2260.dts b/arch/arm/boot/dts/stih410-b2260.dts
index 4fbd8e9eb5b7..1df2c37eb3a7 100644
--- a/arch/arm/boot/dts/stih410-b2260.dts
+++ b/arch/arm/boot/dts/stih410-b2260.dts
@@ -176,6 +176,7 @@
ethernet0: dwmac@9630000 {
phy-mode = "rgmii";
+ phy-handle = <&phy0>;
pinctrl-0 = <&pinctrl_rgmii1 &pinctrl_rgmii1_mdio_1>;
snps,phy-bus-name = "stmmac";
@@ -186,6 +187,15 @@
snps,reset-delays-us = <0 10000 1000000>;
status = "okay";
+
+ mdio0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "snps,dwmac-mdio";
+ phy0: ethernet-phy@0 {
+ reg = <0>;
+ };
+ };
};
sti_uni_player0: sti-uni-player@8d80000 {
--
2.17.1
next prev parent reply other threads:[~2020-01-07 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 12:38 [PATCH 0/2] ARM: dts: stih410-b2260: Fix ethernet PHY " patrice.chotard
2020-01-07 12:38 ` patrice.chotard [this message]
2020-01-07 12:38 ` [PATCH 2/2] ARM: dts: stih410-b2260: Remove deprecated snps PHY properties patrice.chotard
2020-01-08 10:53 ` [PATCH 0/2] ARM: dts: stih410-b2260: Fix ethernet PHY DT node Patrice CHOTARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107123828.6586-2-patrice.chotard@st.com \
--to=patrice.chotard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®