From: Christoph Hellwig <hch@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Christoph Hellwig <hch@infradead.org>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
linux-xfs <linux-xfs@vger.kernel.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Brian Foster <bfoster@redhat.com>,
Dave Chinner <dchinner@redhat.com>,
Allison Collins <allison.henderson@oracle.com>,
Jan Kara <jack@suse.cz>, Eric Sandeen <sandeen@sandeen.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] xfs: disallow broken ioctls without compat-32-bit-time
Date: Tue, 7 Jan 2020 06:15:22 -0800 [thread overview]
Message-ID: <20200107141522.GB10628@infradead.org> (raw)
In-Reply-To: <CAK8P3a30VpwVCSt0kTXZK7r5__80uBGbNOnDh1YhkAkcoBcQrg@mail.gmail.com>
On Thu, Jan 02, 2020 at 09:34:48PM +0100, Arnd Bergmann wrote:
> I tried adding the helper now but ran into a stupid problem: the best
> place to put it would be linux/time32.h, but then I have to include
> linux/compat.h from there, which in turn pulls in tons of other
> headers in any file using linux/time.h.
>
> I considered making it a macro instead, but that's also really ugly.
>
> I now think we should just defer this change until after v5.6, once I
> have separated linux/time.h from linux/time32.h.
> In the meantime I'll resend the other two patches that I know we
> need in v5.6 in order to get there, so Darrick can apply them to his
> tree.
Sounds good.
next prev parent reply other threads:[~2020-01-07 14:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 16:39 [PATCH 1/3] xfs: rename compat_time_t to old_time32_t Arnd Bergmann
2019-12-18 16:39 ` [PATCH 2/3] xfs: disallow broken ioctls without compat-32-bit-time Arnd Bergmann
2019-12-24 8:45 ` Christoph Hellwig
2020-01-02 9:16 ` Arnd Bergmann
2020-01-02 18:07 ` Darrick J. Wong
2020-01-07 14:16 ` Christoph Hellwig
2020-01-07 18:16 ` Darrick J. Wong
2020-01-08 8:57 ` Christoph Hellwig
2020-01-02 20:34 ` Arnd Bergmann
2020-01-07 14:15 ` Christoph Hellwig [this message]
2019-12-18 16:44 ` [PATCH 3/3] xfs: quota: move to time64_t interfaces Arnd Bergmann
2019-12-24 8:39 ` [PATCH 1/3] xfs: rename compat_time_t to old_time32_t Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107141522.GB10628@infradead.org \
--to=hch@infradead.org \
--cc=allison.henderson@oracle.com \
--cc=arnd@arndb.de \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®