From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E080CC33C9B for ; Tue, 7 Jan 2020 14:48:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C12F92077B for ; Tue, 7 Jan 2020 14:48:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728308AbgAGOs6 (ORCPT ); Tue, 7 Jan 2020 09:48:58 -0500 Received: from mga14.intel.com ([192.55.52.115]:18792 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727559AbgAGOs6 (ORCPT ); Tue, 7 Jan 2020 09:48:58 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2020 06:48:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,406,1571727600"; d="scan'208";a="215574314" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 07 Jan 2020 06:48:55 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1ioqAC-0005tX-Lo; Tue, 07 Jan 2020 16:48:56 +0200 Date: Tue, 7 Jan 2020 16:48:56 +0200 From: Andy Shevchenko To: Mika Westerberg Cc: Linus Walleij , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Mathias Nyman Subject: Re: [PATCH] pinctrl: intel: Pass irqchip when adding gpiochip Message-ID: <20200107144856.GI32742@smile.fi.intel.com> References: <20191229013059.495767-1-linus.walleij@linaro.org> <20191230102021.GF2628@lahna.fi.intel.com> <20200107135216.GR465886@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200107135216.GR465886@lahna.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 07, 2020 at 03:52:16PM +0200, Mika Westerberg wrote: > On Tue, Jan 07, 2020 at 11:32:54AM +0100, Linus Walleij wrote: > > On Mon, Dec 30, 2019 at 11:20 AM Mika Westerberg > > wrote: > > > On Sun, Dec 29, 2019 at 02:30:59AM +0100, Linus Walleij wrote: > > > > We need to convert all old gpio irqchips to pass the irqchip > > > > setup along when adding the gpio_chip. For more info see > > > > drivers/gpio/TODO. > > > > > > > > Set up the pin ranges using the new callback. > > > > > > Maybe have this one split as a separate patch? Same what we do for > > > Baytrail and Cherryview. > > > > I'm afraid to do that since splitting the semantic ordering was > > something that broke a lot of times already, I was under the > > impression that doing the two things (moving to the callback > > and adding along with the gpio_chip) at the same time was > > the only way to preserve the semantic ordering. > > Well at least we do the same for others (add the callback in another > patch and then pass irqchip in another) but no strong feelings. I'm fine > with this one as well :) > > > But more than anything I want someone to test it ... > > I quickly tested this on Whiskey Lake and SD card detection interrupt > still works fine after this patch. My understanding that Linus asked to test a proposed (two patch) series... Linus, can you send v2 as series of two patches as Mika suggested? -- With Best Regards, Andy Shevchenko