From: Steven Rostedt <rostedt@goodmis.org>
To: Sven Schnelle <svens@linux.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] selftests/ftrace: fix glob selftest
Date: Tue, 7 Jan 2020 18:42:53 -0500 [thread overview]
Message-ID: <20200107184253.2f97cf3f@gandalf.local.home> (raw)
In-Reply-To: <20200107094047.87758-1-svens@linux.ibm.com>
On Tue, 7 Jan 2020 10:40:47 +0100
Sven Schnelle <svens@linux.ibm.com> wrote:
> test.d/ftrace/func-filter-glob.tc is failing on s390 because it has
> ARCH_INLINE_SPIN_LOCK and friends set to 'y'. So the usual
> __raw_spin_lock symbol isn't in the ftrace function list. Change
> '*aw*lock' to '*spin*lock' which would hopefully match some of the
> locking functions on all platforms.
>
> Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
> ---
> .../testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
> index 27a54a17da65..cf296a3dd723 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
> @@ -30,7 +30,7 @@ ftrace_filter_check '*schedule*' '^.*schedule.*$'
> ftrace_filter_check 'schedule*' '^schedule.*$'
>
> # filter by *mid*end
> -ftrace_filter_check '*aw*lock' '.*aw.*lock$'
> +ftrace_filter_check '*spin*lock' '.*spin.*lock$'
Just to make it not check the beginning, can you remove the 's':
'*pin*lock' '.*pin.*lock$'
Thanks!
-- Steve
>
> # filter by start*mid*
> ftrace_filter_check 'mutex*try*' '^mutex.*try.*'
prev parent reply other threads:[~2020-01-07 23:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 9:40 Sven Schnelle
2020-01-07 23:42 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107184253.2f97cf3f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®