From: Mark Brown <broonie@kernel.org>
To: Saravanan Sekar <sravanhome@gmail.com>
Cc: lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
mripard@kernel.org, shawnguo@kernel.org, heiko@sntech.de,
sam@ravnborg.org, icenowy@aosc.io,
laurent.pinchart@ideasonboard.com, gregkh@linuxfoundation.org,
Jonathan.Cameron@huawei.com, davem@davemloft.net,
mchehab+samsung@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/4] regulator: mpq7920: add mpq7920 regulator driver
Date: Wed, 8 Jan 2020 15:50:56 +0000 [thread overview]
Message-ID: <20200108155056.GA4036@sirena.org.uk> (raw)
In-Reply-To: <20200108131234.24128-4-sravanhome@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 371 bytes --]
On Wed, Jan 08, 2020 at 02:12:33PM +0100, Saravanan Sekar wrote:
> + for_each_child_of_node(np, child) {
> + for (i = 0; i <= MPQ7920_BUCK4; i++) {
> + struct regulator_desc *rdesc = &info->rdesc[i];
> +
> + if (strcmp(rdesc->name, child->name))
> + continue;
You can replace this loop with an of_parse_cb callback, please send an
incremental patch doing this.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-08 15:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 13:12 [PATCH v5 0/4] Add regulator support for mpq7920 Saravanan Sekar
2020-01-08 13:12 ` [PATCH v5 1/4] dt-bindings: Add an entry for Monolithic Power System, MPS Saravanan Sekar
2020-01-08 15:58 ` Mark Brown
2020-01-14 11:10 ` Geert Uytterhoeven
2020-01-08 15:58 ` Applied "dt-bindings: Add an entry for Monolithic Power System, MPS" to the regulator tree Mark Brown
2020-01-08 13:12 ` [PATCH v5 2/4] dt-bindings: regulator: add document bindings for mpq7920 Saravanan Sekar
2020-01-08 15:58 ` Applied "regulator: bindings: add document bindings for mpq7920" to the regulator tree Mark Brown
2020-01-08 13:12 ` [PATCH v5 3/4] regulator: mpq7920: add mpq7920 regulator driver Saravanan Sekar
2020-01-08 15:50 ` Mark Brown [this message]
2020-01-08 13:12 ` [PATCH v5 4/4] MAINTAINERS: Add entry for mpq7920 PMIC driver Saravanan Sekar
2020-01-08 15:58 ` Applied "MAINTAINERS: Add entry for mpq7920 PMIC driver" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108155056.GA4036@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=icenowy@aosc.io \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=sravanhome@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®