From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB479C282DD for ; Wed, 8 Jan 2020 16:39:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B91B720692 for ; Wed, 8 Jan 2020 16:39:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728872AbgAHQjZ (ORCPT ); Wed, 8 Jan 2020 11:39:25 -0500 Received: from mga09.intel.com ([134.134.136.24]:31805 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727127AbgAHQjY (ORCPT ); Wed, 8 Jan 2020 11:39:24 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2020 08:39:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,410,1571727600"; d="scan'208";a="395794858" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga005.jf.intel.com with ESMTP; 08 Jan 2020 08:39:19 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1ipEMZ-0005Rh-8a; Wed, 08 Jan 2020 18:39:19 +0200 Date: Wed, 8 Jan 2020 18:39:19 +0200 From: Andy Shevchenko To: Mika Westerberg Cc: Darren Hart , Lee Jones , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Zha Qipeng , Rajneesh Bhardwaj , "David E . Box" , Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman , Wim Van Sebroeck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 04/36] platform/x86: intel_scu_ipc: Remove Lincroft support Message-ID: <20200108163919.GX32742@smile.fi.intel.com> References: <20200108114201.27908-1-mika.westerberg@linux.intel.com> <20200108114201.27908-5-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200108114201.27908-5-mika.westerberg@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 08, 2020 at 02:41:29PM +0300, Mika Westerberg wrote: > Moorestown support was removed years ago with by the commit 1a8359e411eb > ("x86/mid: Remove Intel Moorestown"). Lincroft is the CPU side chip of > Moorestown and not supported anymore so remove the code from the driver. > Reviewed-by: Andy Shevchenko > Signed-off-by: Mika Westerberg > --- > drivers/platform/x86/intel_scu_ipc.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/intel_scu_ipc.c > index a8be5bcb9832..6c44fe5e55b5 100644 > --- a/drivers/platform/x86/intel_scu_ipc.c > +++ b/drivers/platform/x86/intel_scu_ipc.c > @@ -58,7 +58,6 @@ > #define IPC_RWBUF_SIZE 20 /* IPC Read buffer Size */ > #define IPC_IOC 0x100 /* IPC command register IOC bit */ > > -#define PCI_DEVICE_ID_LINCROFT 0x082a > #define PCI_DEVICE_ID_PENWELL 0x080e > #define PCI_DEVICE_ID_CLOVERVIEW 0x08ea > #define PCI_DEVICE_ID_TANGIER 0x11a0 > @@ -70,12 +69,6 @@ struct intel_scu_ipc_pdata_t { > u8 irq_mode; > }; > > -static const struct intel_scu_ipc_pdata_t intel_scu_ipc_lincroft_pdata = { > - .i2c_base = 0xff12b000, > - .i2c_len = 0x10, > - .irq_mode = 0, > -}; > - > /* Penwell and Cloverview */ > static const struct intel_scu_ipc_pdata_t intel_scu_ipc_penwell_pdata = { > .i2c_base = 0xff12b000, > @@ -677,7 +670,6 @@ static int ipc_probe(struct pci_dev *pdev, const struct pci_device_id *id) > #define SCU_DEVICE(id, pdata) {PCI_VDEVICE(INTEL, id), (kernel_ulong_t)&pdata} > > static const struct pci_device_id pci_ids[] = { > - SCU_DEVICE(PCI_DEVICE_ID_LINCROFT, intel_scu_ipc_lincroft_pdata), > SCU_DEVICE(PCI_DEVICE_ID_PENWELL, intel_scu_ipc_penwell_pdata), > SCU_DEVICE(PCI_DEVICE_ID_CLOVERVIEW, intel_scu_ipc_penwell_pdata), > SCU_DEVICE(PCI_DEVICE_ID_TANGIER, intel_scu_ipc_tangier_pdata), > -- > 2.24.1 > -- With Best Regards, Andy Shevchenko