From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF825C282DD for ; Wed, 8 Jan 2020 17:30:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD0FC20720 for ; Wed, 8 Jan 2020 17:30:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729775AbgAHRaw (ORCPT ); Wed, 8 Jan 2020 12:30:52 -0500 Received: from mga11.intel.com ([192.55.52.93]:8375 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727579AbgAHRaw (ORCPT ); Wed, 8 Jan 2020 12:30:52 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2020 09:30:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,410,1571727600"; d="scan'208";a="223600628" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003.jf.intel.com with ESMTP; 08 Jan 2020 09:30:47 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1ipFAO-00061S-2n; Wed, 08 Jan 2020 19:30:48 +0200 Date: Wed, 8 Jan 2020 19:30:48 +0200 From: Andy Shevchenko To: Mika Westerberg Cc: Darren Hart , Lee Jones , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Zha Qipeng , Rajneesh Bhardwaj , "David E . Box" , Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman , Wim Van Sebroeck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 35/36] mfd: intel_pmc_bxt: Switch to use driver->dev_groups Message-ID: <20200108173048.GW32742@smile.fi.intel.com> References: <20200108114201.27908-1-mika.westerberg@linux.intel.com> <20200108114201.27908-36-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200108114201.27908-36-mika.westerberg@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 08, 2020 at 02:42:00PM +0300, Mika Westerberg wrote: > The driver core provides support for adding additional attributes for > devices via new ->dev_groups member of struct device_driver. I'm wondering if we can also do this before converting to MFD. > Convert the > driver to use that instead of adding the attributes manually. > After addressing above and below comments, Reviewed-by: Andy Shevchenko > Suggested-by: Andy Shevchenko > Signed-off-by: Mika Westerberg > --- > drivers/mfd/intel_pmc_bxt.c | 21 +++++++-------------- > 1 file changed, 7 insertions(+), 14 deletions(-) > > diff --git a/drivers/mfd/intel_pmc_bxt.c b/drivers/mfd/intel_pmc_bxt.c > index 76f166c1455b..9f2eb75bdf78 100644 > --- a/drivers/mfd/intel_pmc_bxt.c > +++ b/drivers/mfd/intel_pmc_bxt.c > @@ -244,6 +244,11 @@ static const struct attribute_group intel_pmc_group = { > .attrs = intel_pmc_attrs, > }; > > +static const struct attribute_group *intel_pmc_groups[] = { > + &intel_pmc_group, > + NULL, Comma is not needed for terminator lines. > +}; > + > static int pmc_create_punit_device(void) > { > struct mfd_cell punit = { > @@ -492,27 +497,14 @@ static int intel_pmc_probe(struct platform_device *pdev) > ret = pmc_create_devices(); > if (ret) { > dev_err(&pdev->dev, "Failed to create pmc devices\n"); > - goto err_ipc; > - } > - > - ret = sysfs_create_group(&pdev->dev.kobj, &intel_pmc_group); > - if (ret) { > - dev_err(&pdev->dev, "Failed to create sysfs group %d\n", > - ret); > - goto err_ipc; > + intel_scu_ipc_remove(scu); > } > > - return 0; > - > -err_ipc: > - intel_scu_ipc_remove(scu); > - > return ret; > } > > static int intel_pmc_remove(struct platform_device *pdev) > { > - sysfs_remove_group(&pdev->dev.kobj, &intel_pmc_group); > intel_scu_ipc_remove(platform_get_drvdata(pdev)); > pmcdev.dev = NULL; > return 0; > @@ -524,6 +516,7 @@ static struct platform_driver intel_pmc_driver = { > .driver = { > .name = "intel_pmc_bxt", > .acpi_match_table = ACPI_PTR(intel_pmc_acpi_ids), > + .dev_groups = intel_pmc_groups, > }, > }; > > -- > 2.24.1 > -- With Best Regards, Andy Shevchenko