From: Chunyan Zhang <zhang.lyra@gmail.com>
To: Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Chunyan Zhang <zhang.lyra@gmail.com>,
Chunyan Zhang <chunyan.zhang@unisoc.com>
Subject: [PATCH] tick-common: touch watchdog for every cpus when system resume
Date: Fri, 10 Jan 2020 16:39:02 +0800 [thread overview]
Message-ID: <20200110083902.27276-1-chunyan.zhang@unisoc.com> (raw)
In the function tick_unfreeze(), it would resume timekeeping for the
first cpu, and for other cpus it does local tick resume only, not
to touch watchdog which is per-cpu as well.
This probably is not the problem for suspend to ram, but for suspend
to idle is. Since watchdog would be setup for each unplugged cores when
plugging during resume and would be touched in its setup process. But for
suspend to idle the system wouldn't unplug/plug cores, so we should
touch watchdog once resume from s2idle to avoid 'soft lockup' warnings
due to timeout detected by watchdog.
Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
---
kernel/time/tick-common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
index 59225b484e4e..7e5d3524e924 100644
--- a/kernel/time/tick-common.c
+++ b/kernel/time/tick-common.c
@@ -11,6 +11,7 @@
#include <linux/err.h>
#include <linux/hrtimer.h>
#include <linux/interrupt.h>
+#include <linux/nmi.h>
#include <linux/percpu.h>
#include <linux/profile.h>
#include <linux/sched.h>
@@ -558,6 +559,7 @@ void tick_unfreeze(void)
trace_suspend_resume(TPS("timekeeping_freeze"),
smp_processor_id(), false);
} else {
+ touch_softlockup_watchdog();
tick_resume_local();
}
--
2.20.1
next reply other threads:[~2020-01-10 8:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 8:39 Chunyan Zhang [this message]
2020-01-15 20:53 ` [tip: timers/core] tick/common: Touch watchdog in tick_unfreeze() on all CPUs tip-bot2 for Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110083902.27276-1-chunyan.zhang@unisoc.com \
--to=zhang.lyra@gmail.com \
--cc=chunyan.zhang@unisoc.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®