From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57E74C282DD for ; Fri, 10 Jan 2020 14:46:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 395CF2082E for ; Fri, 10 Jan 2020 14:46:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728265AbgAJOqE (ORCPT ); Fri, 10 Jan 2020 09:46:04 -0500 Received: from foss.arm.com ([217.140.110.172]:45568 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728012AbgAJOqD (ORCPT ); Fri, 10 Jan 2020 09:46:03 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7E784328; Fri, 10 Jan 2020 06:46:02 -0800 (PST) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 48B0C3F6C4; Fri, 10 Jan 2020 06:46:01 -0800 (PST) Date: Fri, 10 Jan 2020 14:45:55 +0000 From: Lorenzo Pieralisi To: Bjorn Helgaas Cc: David Engraf , thierry.reding@gmail.com, andrew.murray@arm.com, jonathanh@nvidia.com, linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Manikanta Maddireddy Subject: Re: [PATCH v2] PCI: tegra: Fix return value check of pm_runtime_get_sync Message-ID: <20200110144555.GA27048@e121166-lin.cambridge.arm.com> References: <20200109121309.GB10919@e121166-lin.cambridge.arm.com> <20200109182333.GA252736@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109182333.GA252736@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 09, 2020 at 12:23:33PM -0600, Bjorn Helgaas wrote: > On Thu, Jan 09, 2020 at 12:13:09PM +0000, Lorenzo Pieralisi wrote: > > On Tue, Dec 17, 2019 at 08:36:32AM -0600, Bjorn Helgaas wrote: > > > On Mon, Dec 16, 2019 at 12:18:25PM +0100, David Engraf wrote: > > > > pm_runtime_get_sync() returns the device's usage counter. This might > > > > be >0 if the device is already powered up or CONFIG_PM is disabled. > > > > > > > > Abort probe function on real error only. > > > > > > > > Fixes: da76ba50963b ("PCI: tegra: Add power management support") > > > > Signed-off-by: David Engraf > > > > > > I added Andrew's ack and a stable tag for v4.17+. Also cc'd > > > Manikanta, author of da76ba50963b. > > > > > > I put this on my pci/host-tegra branch for v5.6 for now. Lorenzo may > > > move this when he returns. > > > > Hi Bjorn, > > > > I could not find pci/host-tegra in your public repo, have you deleted it > > in the meanwhile ? > > Welcome back, Lorenzo! Sorry, I forgot to push the pci/host-tegra > branch. It has been in -next for a while, though. I pushed it now. > Happy to drop the branch if you want to add more Tegra stuff, just let > me know. Thank you, I will have to add at least another tegra patch so I think it is best to drop your branch, I applied this patch to my pci/tegra branch and pushed it out in the meanwhile. Thanks, Lorenzo