From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA873C33C9E for ; Sat, 11 Jan 2020 08:30:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5FE92077C for ; Sat, 11 Jan 2020 08:30:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728644AbgAKIaX (ORCPT ); Sat, 11 Jan 2020 03:30:23 -0500 Received: from mx.sdf.org ([205.166.94.20]:54569 "EHLO mx.sdf.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728599AbgAKIaX (ORCPT ); Sat, 11 Jan 2020 03:30:23 -0500 Received: from sdf.org (IDENT:lkml@sdf.lonestar.org [205.166.94.16]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 00B8U35n019457 (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits) verified NO); Sat, 11 Jan 2020 08:30:03 GMT Received: (from lkml@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 00B8USV0024843; Sat, 11 Jan 2020 08:30:28 GMT Date: Sat, 11 Jan 2020 08:30:28 GMT From: George Spelvin Message-Id: <202001110830.00B8USV0024843@sdf.org> To: samitolvanen@google.com Subject: Re: [PATCH] lib/list_sort: fix function type mismatches Cc: akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, keescook@chromium.org, linux-kernel@vger.kernel.org, linux@rasmusvillemoes.dk, lkml@sdf.org, mchehab+samsung@kernel.org, st5pub@yandex.ru In-Reply-To: <20200110225602.91663-1-samitolvanen@google.com> References: <20200110225602.91663-1-samitolvanen@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > typedef int __attribute__((nonnull(2,3))) (*cmp_func)(void *, > - struct list_head const *, struct list_head const *); > + struct list_head *, struct list_head *); I'd prefer to leave the const there for documentation. Does anyone object to fixing it in the other direction by *adding* const to all the call sites? Andy Shevchenko posted a patch last 7 October that did that. <20191007135656.37734-1-andriy.shevchenko@linux.intel.com> (You could also try taking a second look at why __pure doesn't work, per AKPM's message of 16 April <20190416154522.65aaa348161fc581181b56d9@linux-foundation.org>)