mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: imu/mpu6050: support dual-edge IRQ
Date: Sat, 11 Jan 2020 16:07:35 +0100	[thread overview]
Message-ID: <20200111150735.GA16291@qmqm.qmqm.pl> (raw)
In-Reply-To: <20200111121047.79e16365@archlinux>

On Sat, Jan 11, 2020 at 12:10:47PM +0000, Jonathan Cameron wrote:
> On Mon, 06 Jan 2020 12:17:54 +0100
> Michał Mirosław <mirq-linux@rere.qmqm.pl> wrote:
> 
> > Make mpu6050 usable on platforms which provide only any-edge interrupts.
> > This also covers shared interrupt case.
> 
> So this had me confused for a bit because I assumed we were trying to make
> a level interrupt providing device work with edge interrupts.  Seems
> device supports a pulsed  mode and the driver supports this.
> 
> Why do we want to detect on both edges?  Do you have a crazy board
> with this shared and some devices using the rising edge and some the falling one?
> 
> For shared case it should return that it did not handle the interrupt
> to allow spurious interrupt detection to work...

Hmm. The shared interrupt is a red herring. I'll remove the sentence
from commitmsg as it looks like the driver needs a few more fixups
to be able to share the interrupt line.

The patch is required on platforms that support only dual-edge
interrupts, like eg. AT91SAM9G45-based one I have.

Best Regards,
Michał Mirosław

  reply	other threads:[~2020-01-11 15:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-04 16:44 [PATCH] " Michał Mirosław
2020-01-06  9:42 ` Jean-Baptiste Maneyrol
2020-01-06 11:17   ` [PATCH v2] " Michał Mirosław
2020-01-06 16:13     ` Jean-Baptiste Maneyrol
2020-01-11 12:10     ` Jonathan Cameron
2020-01-11 15:07       ` Michał Mirosław [this message]
2020-01-13 22:15         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200111150735.GA16291@qmqm.qmqm.pl \
    --to=mirq-linux@rere.qmqm.pl \
    --cc=jic23@kernel.org \
    --cc=jmaneyrol@invensense.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®