From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 135B7C33CB0 for ; Mon, 13 Jan 2020 07:36:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DEF1B2073D for ; Mon, 13 Jan 2020 07:36:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="lxxn4P4H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728829AbgAMHgP (ORCPT ); Mon, 13 Jan 2020 02:36:15 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:32990 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728687AbgAMHgO (ORCPT ); Mon, 13 Jan 2020 02:36:14 -0500 Received: by mail-lf1-f65.google.com with SMTP id n25so6096881lfl.0 for ; Sun, 12 Jan 2020 23:36:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LuCWDSuVOHVDD0RBreB5I3crH+JdvuDeEnJ61QwIlv8=; b=lxxn4P4HGDQDftUPfcUemr7aW0pZLgel+N/hMr05xUbY+zyc2C1asmbnF6WPrEe2Cy u1IDuJpghF8gQzagcU0NMmHaVJC4muTGR1pTq+v9V9/kzo0AEL8uqQb9m4VJEi1ytNbR G2HU5EagSfAV5/K8u7iszKZ/zUWBPWWrMfDsfYJqp+POEF4FBiF6PsF2vJY/LdmBUb2j xeAI5U+PGhP0ScNDzJRKW7lGHn3YqkFDMBvv0mCjjIFr88NXimk4yZbuOwVeyrfXUHr/ gFZvAgDZdLT4fuqPJ80e4hLpWqQmNcRTbeJPh3JigUeAuGHwaXOFEy3/INoEC0+kn/lD cHcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LuCWDSuVOHVDD0RBreB5I3crH+JdvuDeEnJ61QwIlv8=; b=G93p8JW89eroG4cvUHR+ibORkaeVRdL5MKE+bpC7pfySgAP43/AFTgbMM+jnanjT4F T0GiSj7e87Ud8vCwbGOtB62vDjVRqmAz2dk1+Gta72qvFGIll3xBiYkttYMoxiKw2c3T jXNXY0SyMmcYwu+Hy+5fgeaeJJcPdR+8P1NzsoXrrhVuPDi9Xv4MpQb8P8S6HbM8Y0kN LC14pQ+tLRjG9mGmyPwhSn7uA7kMBjxGOcL9f/z7/WtSss/XJAFJIs1D/AnghFLU9UjC DQQkaUh1S+JT2hrEfZOD7VJZYnyLYXWdGBfHm6iHVVTfec3Vv/uDInxhhVc7atvLhGXS iRPw== X-Gm-Message-State: APjAAAUi9KAVxkpZRW7QIAGBE+2PXTJkpzUtNPII4/+4Ta1F9D/YgiBH eIfMvaFzGbBJtBjPO1QG9pJAzw== X-Google-Smtp-Source: APXvYqzpxmHesE/c6JuNwGxLjvBVFrG/i69Jzm2Jvf0XSNKN28YoqY5Exph+JvJFaL9arlLhJ+stng== X-Received: by 2002:ac2:57cc:: with SMTP id k12mr8925268lfo.36.1578900972267; Sun, 12 Jan 2020 23:36:12 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id s13sm5455116lje.35.2020.01.12.23.36.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jan 2020 23:36:11 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id A8B1E1008E9; Mon, 13 Jan 2020 10:36:14 +0300 (+03) Date: Mon, 13 Jan 2020 10:36:14 +0300 From: "Kirill A. Shutemov" To: Wei Yang Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kirill.shutemov@linux.intel.com, yang.shi@linux.alibaba.com, alexander.duyck@gmail.com, rientjes@google.com Subject: Re: [Patch v2] mm: thp: grab the lock before manipulation defer list Message-ID: <20200113073614.jo2txcmazwlesl7b@box.shutemov.name> References: <20200109143054.13203-1-richardw.yang@linux.intel.com> <20200111000352.efy6krudecpshezh@box> <20200112022858.GA17733@richard> <20200112225718.5vqzezfclacujyx3@box> <20200113004457.GA27762@richard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200113004457.GA27762@richard> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 13, 2020 at 08:44:57AM +0800, Wei Yang wrote: > >> It is possible two page in the same pgdate or memcg grab page lock > >> respectively and then access the same defer queue concurrently. > > If my understanding is correct, you agree with my statement? Which one? If the one above then no. list_empty only accesses list_head for the struct page, not the queue. -- Kirill A. Shutemov