From: Mark Brown <broonie@kernel.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
kbuild test robot <lkp@intel.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v2 2/2] spi: fsl: simplify error path in of_fsl_spi_probe()
Date: Tue, 14 Jan 2020 15:35:08 +0000 [thread overview]
Message-ID: <20200114153508.GY3897@sirena.org.uk> (raw)
In-Reply-To: <539a3b82463f64e8055f166c915f0e90f752c7b0.1575990944.git.christophe.leroy@c-s.fr>
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
On Tue, Dec 10, 2019 at 03:17:16PM +0000, Christophe Leroy wrote:
> No need to 'goto err;' for just doing a return.
> return directly from where the error happens.
This doesn't apply against current code, please check and resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-14 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 15:17 [PATCH v2 1/2] spi: fsl: don't map irq during probe Christophe Leroy
2019-12-10 15:17 ` [PATCH v2 2/2] spi: fsl: simplify error path in of_fsl_spi_probe() Christophe Leroy
2020-01-14 15:35 ` Mark Brown [this message]
2019-12-10 19:20 ` [PATCH v2 1/2] spi: fsl: don't map irq during probe Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114153508.GY3897@sirena.org.uk \
--to=broonie@kernel.org \
--cc=christophe.leroy@c-s.fr \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®