From: Christoph Hellwig <hch@lst.de>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com,
Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Juergen Gross <jgross@suse.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Manish Narani <manish.narani@xilinx.com>,
Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Stafford Horne <shorne@gmail.com>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH] microblaze: Wire CMA allocator
Date: Tue, 14 Jan 2020 16:47:44 +0100 [thread overview]
Message-ID: <20200114154744.GB7194@lst.de> (raw)
In-Reply-To: <1a1a4c1e0f930e4fc0dfc785dbce57c07303f1a6.1579003045.git.michal.simek@xilinx.com>
On Tue, Jan 14, 2020 at 12:57:28PM +0100, Michal Simek wrote:
> Based on commit 04e3543e228f ("microblaze: use the generic dma coherent remap allocator")
> CMA can be easily enabled by calling dma_contiguous_reserve() at the end of
> mmu_init(). High limit is end of lowmem space which is completely unused at
> this point of time.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Christoph: Can you please review this patch?
Looks sensible to me. If you touch this area anyway I have a request,
though:
> +++ b/arch/microblaze/include/asm/Kbuild
> @@ -7,6 +7,7 @@ generic-y += bugs.h
> generic-y += compat.h
> generic-y += device.h
> generic-y += div64.h
> +generic-y += dma-contiguous.h
Can you add a prep patch to add a
mandatory-y += dma-contiguous.h
to include/asm-generic/Kbuild and remove the generic-y in all the
arch files? That reduces the arch churn a little.
next prev parent reply other threads:[~2020-01-14 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 11:57 Michal Simek
2020-01-14 15:47 ` Christoph Hellwig [this message]
2020-01-17 7:51 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114154744.GB7194@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=jcmvbkbc@gmail.com \
--cc=jgross@suse.com \
--cc=kstewart@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=manjukumar.harthikote-matha@xilinx.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=rppt@linux.ibm.com \
--cc=shorne@gmail.com \
--cc=will@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®