From: Mark Brown <broonie@kernel.org>
To: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: "christophe.leroy@c-s.fr" <christophe.leroy@c-s.fr>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lkp@intel.com" <lkp@intel.com>,
"geert@linux-m68k.org" <geert@linux-m68k.org>
Subject: Re: [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe()
Date: Tue, 14 Jan 2020 16:57:39 +0000 [thread overview]
Message-ID: <20200114165739.GC3897@sirena.org.uk> (raw)
In-Reply-To: <b6d01fa02e659db911df63a79d825080f03dfcb8.camel@infinera.com>
[-- Attachment #1: Type: text/plain, Size: 169 bytes --]
On Tue, Jan 14, 2020 at 04:26:18PM +0000, Joakim Tjernlund wrote:
> Don't you need to "undo" ioremap, irq etc. in case of later errors?
Better, convert to devm_
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-01-14 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 16:02 Christophe Leroy
2020-01-14 16:09 ` Applied "spi: fsl: simplify error path in of_fsl_spi_probe()" to the spi tree Mark Brown
2020-01-14 16:26 ` [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe() Joakim Tjernlund
2020-01-14 16:57 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114165739.GC3897@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Joakim.Tjernlund@infinera.com \
--cc=christophe.leroy@c-s.fr \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®