From: Peter Zijlstra <peterz@infradead.org>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: linux-kernel@vger.kernel.org, sudeep.holla@arm.com,
prime.zeng@hisilicon.com, dietmar.eggemann@arm.com,
morten.rasmussen@arm.com, mingo@kernel.org
Subject: Re: [PATCH] sched/topology: Assert non-NUMA topology masks don't (partially) overlap
Date: Thu, 16 Jan 2020 16:19:42 +0100 [thread overview]
Message-ID: <20200116151942.GW2871@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200116104428.GP2827@hirez.programming.kicks-ass.net>
On Thu, Jan 16, 2020 at 11:44:28AM +0100, Peter Zijlstra wrote:
> On Wed, Jan 15, 2020 at 04:09:15PM +0000, Valentin Schneider wrote:
> > @@ -1975,6 +2011,9 @@ build_sched_domains(const struct cpumask *cpu_map, struct sched_domain_attr *att
> > has_asym = true;
> > }
> >
> > + if (WARN_ON(!topology_span_sane(tl, cpu_map, i)))
> > + goto error;
> > +
> > sd = build_sched_domain(tl, cpu_map, attr, sd, dflags, i);
> >
> > if (tl == sched_domain_topology)
>
> This is O(nr_cpus), but then, that function already is, so I don't see a
> problem with this.
Clearly I meant to write O(nr_cpus^2), there's a bunch of nested
for_each_cpu() in there.
> I'll take it, thanks!
next prev parent reply other threads:[~2020-01-16 15:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 16:09 Valentin Schneider
2020-01-16 10:44 ` Peter Zijlstra
2020-01-16 10:48 ` Valentin Schneider
2020-01-16 15:19 ` Peter Zijlstra [this message]
2020-01-16 15:30 ` Valentin Schneider
2020-01-17 10:08 ` [tip: sched/core] " tip-bot2 for Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116151942.GW2871@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=prime.zeng@hisilicon.com \
--cc=sudeep.holla@arm.com \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®