From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9840BC33CAF for ; Thu, 16 Jan 2020 19:23:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73FBA207E0 for ; Thu, 16 Jan 2020 19:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579202615; bh=Z+ca/Va9xfC4txSFybMjsDEoHiJWx4ekssX8s8xihU4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=oq+YvTgKz5D8rfPjHWtLHu/c3qKWhvqJqjqaFl7nZPgusNc6hrp+3vSMuMNWFlgE3 OhnEYiM4bLAwTJmsZ5kDfLKuaU9Ijjiw02xlsEal0LnBdvSCozLMYcbWVBqer1STwz DnO5bSMQaT4jFweM619lnoC3S77N6QUJ8Wa20qAo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437758AbgAPTXb (ORCPT ); Thu, 16 Jan 2020 14:23:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:36790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730688AbgAPQxK (ORCPT ); Thu, 16 Jan 2020 11:53:10 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 824F0214AF; Thu, 16 Jan 2020 16:53:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579193590; bh=Z+ca/Va9xfC4txSFybMjsDEoHiJWx4ekssX8s8xihU4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rU8d0fScclD6UQj6XCTtulu1s/iAKG03kZGgZIAoo+QVplfvqppIBbt4uBkTy92O+ YBhALFfFsFwgsZRpwb+rGIAywC+gJdPHmWbKWdQ4ppAvjUJvQvnGl9ggOFkcx1wKyV JMy0aVxBStGx9Ovy4AuP9KeQQiLgB5xdluv3AXZg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Markus Elfring , Tony Lindgren , Sasha Levin , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 130/205] ARM: OMAP2+: Add missing put_device() call in omapdss_init_of() Date: Thu, 16 Jan 2020 11:41:45 -0500 Message-Id: <20200116164300.6705-130-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116164300.6705-1-sashal@kernel.org> References: <20200116164300.6705-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring [ Upstream commit 0b491904f053e41685162af5c5411b85b18c97a7 ] A coccicheck run provided information like the following. arch/arm/mach-omap2/display.c:268:2-8: ERROR: missing put_device; call of_find_device_by_node on line 258, but without a corresponding object release within this function. Generated by: scripts/coccinelle/free/put_device.cocci Thus add the missed function call to fix the exception handling for this function implementation. Fixes: e0c827aca0730b51f38081aa4e8ecf0912aab55f ("drm/omap: Populate DSS children in omapdss driver") Signed-off-by: Markus Elfring Signed-off-by: Tony Lindgren Signed-off-by: Sasha Levin --- arch/arm/mach-omap2/display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c index 439e143cad7b..46012ca812f4 100644 --- a/arch/arm/mach-omap2/display.c +++ b/arch/arm/mach-omap2/display.c @@ -265,6 +265,7 @@ static int __init omapdss_init_of(void) r = of_platform_populate(node, NULL, NULL, &pdev->dev); if (r) { pr_err("Unable to populate DSS submodule devices\n"); + put_device(&pdev->dev); return r; } -- 2.20.1