From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Shile Zhang <shile.zhang@linux.alibaba.com>
Cc: Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: use $(SRCARCH) to avoid compile error with ARCH=x86_64
Date: Fri, 17 Jan 2020 10:44:07 -0600 [thread overview]
Message-ID: <20200117164407.3xkrhx7yrey2ccel@treble> (raw)
In-Reply-To: <20191227022931.142690-1-shile.zhang@linux.alibaba.com>
On Fri, Dec 27, 2019 at 10:29:31AM +0800, Shile Zhang wrote:
> To build objtool with ARCH=x86_64 will failed as:
>
> $make ARCH=x86_64 -C tools/objtool
> ...
> CC arch/x86/decode.o
> arch/x86/decode.c:10:22: fatal error: asm/insn.h: No such file or directory
> #include <asm/insn.h>
> ^
> compilation terminated.
> mv: cannot stat ‘arch/x86/.decode.o.tmp’: No such file or directory
> make[2]: *** [arch/x86/decode.o] Error 1
> ...
>
> The root cause is the command-line variable 'ARCH' cannot be overridden.
> It can be replaced by the one 'SRCARCH' defined in
> 'tools/scripts/Makefile.arch'.
>
> Signed-off-by: Shile Zhang <shile.zhang@linux.alibaba.com>
Thanks. I'll submit it to the -tip tree.
--
Josh
prev parent reply other threads:[~2020-01-17 16:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 2:29 Shile Zhang
2020-01-03 12:48 ` Kamalesh Babulal
2020-01-17 16:44 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117164407.3xkrhx7yrey2ccel@treble \
--to=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=shile.zhang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®