From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B1B1C33C9E for ; Fri, 17 Jan 2020 18:57:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B80F20842 for ; Fri, 17 Jan 2020 18:57:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729623AbgAQS5n (ORCPT ); Fri, 17 Jan 2020 13:57:43 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:38006 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729546AbgAQS5k (ORCPT ); Fri, 17 Jan 2020 13:57:40 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 6195F20028; Fri, 17 Jan 2020 19:57:38 +0100 (CET) Date: Fri, 17 Jan 2020 19:57:37 +0100 From: Sam Ravnborg To: Bartlomiej Zolnierkiewicz Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] video: fbdev: w100fb: fix sparse warnings Message-ID: <20200117185737.GB24508@ravnborg.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=hD80L64hAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=jGXlrUAzkbCyByQ0p6wA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 16, 2020 at 03:53:20PM +0100, Bartlomiej Zolnierkiewicz wrote: > * Add missing __iomem annotations where needed. > * Make w100fb_probe() static. > * Return NULL pointer (instead of using plain integer) in > w100_get_xtal_tabl(). > > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sam Ravnborg > --- > drivers/video/fbdev/w100fb.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > Index: b/drivers/video/fbdev/w100fb.c > =================================================================== > --- a/drivers/video/fbdev/w100fb.c > +++ b/drivers/video/fbdev/w100fb.c > @@ -61,9 +61,9 @@ struct w100_pll_info *w100_get_xtal_tabl > #define BITS_PER_PIXEL 16 > > /* Remapped addresses for base cfg, memmapped regs and the frame buffer itself */ > -static void *remapped_base; > -static void *remapped_regs; > -static void *remapped_fbuf; > +static void __iomem *remapped_base; > +static void __iomem *remapped_regs; > +static void __iomem *remapped_fbuf; > > #define REMAPPED_FB_LEN 0x15ffff > > @@ -635,7 +635,7 @@ static int w100fb_resume(struct platform > #endif > > > -int w100fb_probe(struct platform_device *pdev) > +static int w100fb_probe(struct platform_device *pdev) > { > int err = -EIO; > struct w100fb_mach_info *inf; > @@ -807,10 +807,11 @@ static int w100fb_remove(struct platform > > static void w100_soft_reset(void) > { > - u16 val = readw((u16 *) remapped_base + cfgSTATUS); > - writew(val | 0x08, (u16 *) remapped_base + cfgSTATUS); > + u16 val = readw((u16 __iomem *)remapped_base + cfgSTATUS); > + > + writew(val | 0x08, (u16 __iomem *)remapped_base + cfgSTATUS); > udelay(100); > - writew(0x00, (u16 *) remapped_base + cfgSTATUS); > + writew(0x00, (u16 __iomem *)remapped_base + cfgSTATUS); > udelay(100); > } > > @@ -1022,7 +1023,8 @@ struct w100_pll_info *w100_get_xtal_tabl > return pll_entry->pll_table; > pll_entry++; > } while (pll_entry->xtal_freq); > - return 0; > + > + return NULL; > } > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel