From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1739CC2D0DB for ; Mon, 20 Jan 2020 14:33:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E69EE22522 for ; Mon, 20 Jan 2020 14:33:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728709AbgATOdk (ORCPT ); Mon, 20 Jan 2020 09:33:40 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:37259 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726626AbgATOdk (ORCPT ); Mon, 20 Jan 2020 09:33:40 -0500 Received: from [154.119.55.242] (helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1itY7T-0004eh-K1; Mon, 20 Jan 2020 14:33:38 +0000 Date: Mon, 20 Jan 2020 15:33:30 +0100 From: Christian Brauner To: Oleg Nesterov Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo , Johannes Weiner , Li Zefan , cgroups@vger.kernel.org Subject: Re: [PATCH v4 3/6] cgroup: refactor fork helpers Message-ID: <20200120143329.o7cmmemfqexk3x37@wittgenstein> References: <20200117181219.14542-1-christian.brauner@ubuntu.com> <20200117181219.14542-4-christian.brauner@ubuntu.com> <20200120140029.GB30403@redhat.com> <20200120140452.qyjogmmhyqc3gxon@wittgenstein> <20200120142202.GC30403@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200120142202.GC30403@redhat.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 20, 2020 at 03:22:03PM +0100, Oleg Nesterov wrote: > On 01/20, Christian Brauner wrote: > > > > On Mon, Jan 20, 2020 at 03:00:30PM +0100, Oleg Nesterov wrote: > > > This is probably the only patch in series I can understand ;) > > > > > > To me it looks like a good cleanup regardless, but > > > > > > On 01/17, Christian Brauner wrote: > > > > > > > > The patch just passes in the parent task_struct > > > > > > For what? "parent" is always "current", no? > > > > Yes. What exactly are you hinting at? :) Would you prefer that the > > commit message speaks of "current" instead of "parent"? > > I meant, I don't understand why did you add the new "parent" arg, > cgroup_xxx_fork() can simply use "current" ? There's no specific reason behind it. I don't care much whether it's an arg or we just grab current in each helper directly. Christian