From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CBB6C2D0DB for ; Mon, 20 Jan 2020 15:06:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6CD32217F4 for ; Mon, 20 Jan 2020 15:06:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729144AbgATPGA (ORCPT ); Mon, 20 Jan 2020 10:06:00 -0500 Received: from mga03.intel.com ([134.134.136.65]:5464 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729076AbgATPF7 (ORCPT ); Mon, 20 Jan 2020 10:05:59 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jan 2020 07:05:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,342,1574150400"; d="scan'208";a="275592142" Received: from kuha.fi.intel.com ([10.237.72.53]) by fmsmga001.fm.intel.com with SMTP; 20 Jan 2020 07:05:55 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Mon, 20 Jan 2020 17:05:54 +0200 Date: Mon, 20 Jan 2020 17:05:54 +0200 From: Heikki Krogerus To: Thomas Hebb Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Greg Kroah-Hartman , Guenter Roeck , Hans de Goede , linux-usb@vger.kernel.org Subject: Re: [PATCH v3 2/2] usb: typec: fusb302: fix "op-sink-microwatt" default that was in mW Message-ID: <20200120150554.GH32175@kuha.fi.intel.com> References: <0da564559af75ec829c6c7e3aa4024f857c91bee.1579529334.git.tommyhebb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0da564559af75ec829c6c7e3aa4024f857c91bee.1579529334.git.tommyhebb@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 20, 2020 at 06:09:06AM -0800, Thomas Hebb wrote: > commit 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the > port") didn't convert this value from mW to uW when migrating to a new > specification format like it should have. > > Fixes: 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the port") > Cc: stable@vger.kernel.org > Signed-off-by: Thomas Hebb Reviewed-by: Heikki Krogerus > --- > > Changes in v3: None > Changes in v2: None > > drivers/usb/typec/tcpm/fusb302.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c > index ed8655c6af8c..b498960ff72b 100644 > --- a/drivers/usb/typec/tcpm/fusb302.c > +++ b/drivers/usb/typec/tcpm/fusb302.c > @@ -1666,7 +1666,7 @@ static const struct property_entry port_props[] = { > PROPERTY_ENTRY_STRING("try-power-role", "sink"), > PROPERTY_ENTRY_U32_ARRAY("source-pdos", src_pdo), > PROPERTY_ENTRY_U32_ARRAY("sink-pdos", snk_pdo), > - PROPERTY_ENTRY_U32("op-sink-microwatt", 2500), > + PROPERTY_ENTRY_U32("op-sink-microwatt", 2500000), > { } > }; > > -- > 2.24.1 thanks, -- heikki