From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D065C2D0DB for ; Mon, 20 Jan 2020 17:55:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A88522314 for ; Mon, 20 Jan 2020 17:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579542958; bh=TOl9ykBL6v4Z7lUHO9KTQ7wq+ACISXVmRYMF7MA98d8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rTeSizGd876YeMl4e8wEaXqbl4xEj1XqG0H5egS8zkyendYlfT9OEahyAK0xJr3Y0 edw6UBIlKfBETTGeAA00LkzEI+JdJWK37XArhFVg9LBv3WFZ1kEr0vnXUtSAz7DqIJ 6FVH0Woim+SIBV7WkAWZKrd6owXF4DEC6gA85m/8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728093AbgATRz5 (ORCPT ); Mon, 20 Jan 2020 12:55:57 -0500 Received: from foss.arm.com ([217.140.110.172]:35258 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726982AbgATRz5 (ORCPT ); Mon, 20 Jan 2020 12:55:57 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8F30031B; Mon, 20 Jan 2020 09:55:56 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0E7343F68E; Mon, 20 Jan 2020 09:55:55 -0800 (PST) Date: Mon, 20 Jan 2020 17:55:54 +0000 From: Mark Brown To: Andy Shevchenko Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , alsa-devel@alsa-project.org Subject: Re: [PATCH v2 9/9] ASoC: Intel: Switch DMI table match to a test of variable Message-ID: <20200120175554.GK6852@sirena.org.uk> References: <20200120160801.53089-1-andriy.shevchenko@linux.intel.com> <20200120160801.53089-10-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ucgz5Oc/kKURWzXs" Content-Disposition: inline In-Reply-To: <20200120160801.53089-10-andriy.shevchenko@linux.intel.com> X-Cookie: I invented skydiving in 1989! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Ucgz5Oc/kKURWzXs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 20, 2020 at 06:08:01PM +0200, Andy Shevchenko wrote: > Since we have a common x86 quirk that provides an exported variable, > use it instead of local DMI table match. Acked-by: Mark Brown > - if (cht_machine_id == CHT_SURFACE_MACH) > - return &cht_surface_mach; > - else > - return mach; > + return x86_microsoft_surface_3_machine ? &cht_surface_mach : arg; but if you're respinning this please replace this with a normal conditional statement to improve legibility. --Ucgz5Oc/kKURWzXs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4l6akACgkQJNaLcl1U h9CSpgf+MMjb+D55JRRorEe3BQ4M1I3cFOs+Bj/gzwORglvmHGKTGAvV4lt9Qz3Y 7mOitkpYtKoUpXSAr9xlxfMdYQvEGex599+4KCS76A1gdAjcIOwejaJcq8N88Lnw s2kogJgt5nteihn7spBaT2scBUCkhwF25jCTjfFDVVgk6vTANDjja0sLL13rg2Rl 0a6fXh5ZSVgmi9ckouFC8b1K2YLBJ0kwSBtONXBvWfttQG8taOfwdNk363e8simL gR67f8gexPh7rjX3f77QMdlmKx9UPWoeh6IkFVL3LOwJNM8j42mwipTK29++JYaf G2s1Eo7nbPCkXGnwWzwr5ANfbhqzog== =KRvr -----END PGP SIGNATURE----- --Ucgz5Oc/kKURWzXs--