From: Chen Zhou <chenzhou10@huawei.com>
To: <jens.wiklander@linaro.org>
Cc: <gary.hook@amd.com>, <Devaraj.Rangasamy@amd.com>,
<Rijo-john.Thomas@amd.com>, <herbert@gondor.apana.org.au>,
<tee-dev@lists.linaro.org>, <linux-kernel@vger.kernel.org>,
<chenzhou10@huawei.com>
Subject: [PATCH -next] tee: amdtee: fix return value check in amdtee_driver_init
Date: Tue, 21 Jan 2020 09:38:12 +0800 [thread overview]
Message-ID: <20200121013812.18153-1-chenzhou10@huawei.com> (raw)
Allocation function kzalloc returns NULL not ERR_PTR on failure.
Replace IS_ERR with NULL check.
Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/tee/amdtee/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c
index be8937e..6370bb5 100644
--- a/drivers/tee/amdtee/core.c
+++ b/drivers/tee/amdtee/core.c
@@ -446,11 +446,11 @@ static int __init amdtee_driver_init(void)
}
drv_data = kzalloc(sizeof(*drv_data), GFP_KERNEL);
- if (IS_ERR(drv_data))
+ if (!drv_data)
return -ENOMEM;
amdtee = kzalloc(sizeof(*amdtee), GFP_KERNEL);
- if (IS_ERR(amdtee)) {
+ if (!amdtee) {
rc = -ENOMEM;
goto err_kfree_drv_data;
}
--
2.7.4
reply other threads:[~2020-01-21 1:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121013812.18153-1-chenzhou10@huawei.com \
--to=chenzhou10@huawei.com \
--cc=Devaraj.Rangasamy@amd.com \
--cc=Rijo-john.Thomas@amd.com \
--cc=gary.hook@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=jens.wiklander@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tee-dev@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®