mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chen Zhou <chenzhou10@huawei.com>
To: <alexander.deucher@amd.com>, <christian.koenig@amd.com>,
	<David1.Zhou@amd.com>, <airlied@linux.ie>, <daniel@ffwll.ch>
Cc: <tao.zhou1@amd.com>, <Hawking.Zhang@amd.com>,
	<Felix.Kuehling@amd.com>, <amd-gfx@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<chenzhou10@huawei.com>
Subject: [PATCH -next 04/14] drm/amdgpu: remove unnecessary conversion to bool in gfx_v10_0.c
Date: Tue, 21 Jan 2020 21:55:30 +0800	[thread overview]
Message-ID: <20200121135540.165798-5-chenzhou10@huawei.com> (raw)
In-Reply-To: <20200121135540.165798-1-chenzhou10@huawei.com>

Fixes coccicheck warning:

./drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:4259:43-48: WARNING:
	conversion to bool not needed here

and many more similar messages.

Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c  | 4 ++--
 drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 1cfc508..3da9d79 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
@@ -4230,7 +4230,7 @@ static int gfx_v10_0_set_powergating_state(void *handle,
 					  enum amd_powergating_state state)
 {
 	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
-	bool enable = (state == AMD_PG_STATE_GATE) ? true : false;
+	bool enable = state == AMD_PG_STATE_GATE;
 	switch (adev->asic_type) {
 	case CHIP_NAVI10:
 	case CHIP_NAVI14:
@@ -4256,7 +4256,7 @@ static int gfx_v10_0_set_clockgating_state(void *handle,
 	case CHIP_NAVI14:
 	case CHIP_NAVI12:
 		gfx_v10_0_update_gfx_clock_gating(adev,
-						 state == AMD_CG_STATE_GATE ? true : false);
+						 state == AMD_CG_STATE_GATE);
 		break;
 	default:
 		break;
diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c
index a7cb185..bde1896 100644
--- a/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c
@@ -427,9 +427,9 @@ int mmhub_v2_0_set_clockgating(struct amdgpu_device *adev,
 	case CHIP_NAVI14:
 	case CHIP_NAVI12:
 		mmhub_v2_0_update_medium_grain_clock_gating(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		mmhub_v2_0_update_medium_grain_light_sleep(adev,
-				state == AMD_CG_STATE_GATE ? true : false);
+				state == AMD_CG_STATE_GATE);
 		break;
 	default:
 		break;
-- 
2.7.4


  parent reply	other threads:[~2020-01-21 14:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-21 13:55 [PATCH -next 00/14] drm/amdgpu: remove unnecessary conversion to bool Chen Zhou
2020-01-21 13:55 ` [PATCH -next 01/14] drm/amdgpu: remove unnecessary conversion to bool in mmhub_v1_0.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 02/14] drm/amdgpu: remove unnecessary conversion to bool in vega10_ih.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 03/14] drm/amdgpu: remove unnecessary conversion to bool in navi10_ih.c Chen Zhou
2020-01-21 13:55 ` Chen Zhou [this message]
2020-01-21 13:55 ` [PATCH -next 05/14] drm/amdgpu: remove unnecessary conversion to bool in sdma_v5_0.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 06/14] drm/amdgpu: remove unnecessary conversion to bool in athub_v1_0.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 07/14] drm/amdgpu: remove unnecessary conversion to bool in amdgpu_acp.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 08/14] drm/amdgpu: remove unnecessary conversion to bool in soc15.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 09/14] drm/amdgpu: remove unnecessary conversion to bool in nv.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 10/14] drm/amdgpu: remove unnecessary conversion to bool in mmhub_v9_4.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 11/14] drm/amdgpu: remove unnecessary conversion to bool in amdgpu_device.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 12/14] drm/amdgpu: remove unnecessary conversion to bool in athub_v2_0.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 13/14] drm/amdgpu: remove unnecessary conversion to bool in sdma_v4_0.c Chen Zhou
2020-01-21 13:55 ` [PATCH -next 14/14] drm/amdgpu: remove unnecessary conversion to bool in gfx_v9_0.c Chen Zhou
2020-01-22 20:21 ` [PATCH -next 00/14] drm/amdgpu: remove unnecessary conversion to bool Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200121135540.165798-5-chenzhou10@huawei.com \
    --to=chenzhou10@huawei.com \
    --cc=David1.Zhou@amd.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=Hawking.Zhang@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tao.zhou1@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®