From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57101C2D0CE for ; Tue, 21 Jan 2020 16:33:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A6E122525 for ; Tue, 21 Jan 2020 16:33:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729099AbgAUQdS (ORCPT ); Tue, 21 Jan 2020 11:33:18 -0500 Received: from mga14.intel.com ([192.55.52.115]:38444 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726968AbgAUQdR (ORCPT ); Tue, 21 Jan 2020 11:33:17 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jan 2020 08:33:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,346,1574150400"; d="scan'208";a="280046622" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 21 Jan 2020 08:33:12 -0800 Received: by lahna (sSMTP sendmail emulation); Tue, 21 Jan 2020 18:33:12 +0200 Date: Tue, 21 Jan 2020 18:33:12 +0200 From: Mika Westerberg To: Mark Brown Cc: Andy Shevchenko , Darren Hart , Lee Jones , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Zha Qipeng , "David E . Box" , Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman , Wim Van Sebroeck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 00/38] platform/x86: Rework intel_scu_ipc and intel_pmc_ipc drivers Message-ID: <20200121163312.GZ2665@lahna.fi.intel.com> References: <20200121160114.60007-1-mika.westerberg@linux.intel.com> <20200121162157.GD4656@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200121162157.GD4656@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 21, 2020 at 04:21:57PM +0000, Mark Brown wrote: > On Tue, Jan 21, 2020 at 07:00:36PM +0300, Mika Westerberg wrote: > > > Currently both intel_scu_ipc.c and intel_pmc_ipc.c implement the same SCU > > IPC communications with minor differences. This duplication does not make > > much sense so this series reworks the two drivers so that there is only a > > single implementation of the SCU IPC. In addition to that the API will be > > This is a 40 (!) patch series and looking at the subjects and diffstat I > can't tell if there's something in particular that you're looking for me > to review? Sorry about that. I included you because there was suggestion from Lee to convert the MFD driver in patch 37 to use regmap but the registers are all 64-bit and it was not clear whether regmap supports that: https://www.spinics.net/lists/platform-driver-x86/msg20652.html Looking at the regmap API it seems to deal mostly with "unsigned int" which does not work well with the 64-bit MMIO registers but I may be missing something.