From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB345C33CAA for ; Tue, 21 Jan 2020 16:52:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BA5821569 for ; Tue, 21 Jan 2020 16:52:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729276AbgAUQwP (ORCPT ); Tue, 21 Jan 2020 11:52:15 -0500 Received: from foss.arm.com ([217.140.110.172]:45822 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726555AbgAUQwP (ORCPT ); Tue, 21 Jan 2020 11:52:15 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E985328; Tue, 21 Jan 2020 08:52:15 -0800 (PST) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0F2653F6C4; Tue, 21 Jan 2020 08:52:13 -0800 (PST) Date: Tue, 21 Jan 2020 16:52:08 +0000 From: Lorenzo Pieralisi To: Kishon Vijay Abraham I Cc: Murali Karicheri , Andrew Murray , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: keystone: Fix error handling when "num-viewport" DT property is not populated Message-ID: <20200121165208.GA21742@e121166-lin.cambridge.arm.com> References: <20200121115734.7047-1-kishon@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200121115734.7047-1-kishon@ti.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 21, 2020 at 05:27:34PM +0530, Kishon Vijay Abraham I wrote: > Fix error handling when "num-viewport" DT property is not populated. > > Fixes: 23284ad677a94 ("PCI: keystone: Add support for PCIe EP in AM654x Platforms") > Cc: stable@vger.kernel.org # v5.2+ > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/pci/controller/dwc/pci-keystone.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to pci/keystone, thanks. Lorenzo > diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c > index dbe31589eb61..2c127c321080 100644 > --- a/drivers/pci/controller/dwc/pci-keystone.c > +++ b/drivers/pci/controller/dwc/pci-keystone.c > @@ -1357,7 +1357,7 @@ static int __init ks_pcie_probe(struct platform_device *pdev) > ret = of_property_read_u32(np, "num-viewport", &num_viewport); > if (ret < 0) { > dev_err(dev, "unable to read *num-viewport* property\n"); > - return ret; > + goto err_get_sync; > } > > /* > -- > 2.17.1 >