From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8ECBC33CAF for ; Tue, 21 Jan 2020 20:26:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E67824125 for ; Tue, 21 Jan 2020 20:26:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728855AbgAUU0I (ORCPT ); Tue, 21 Jan 2020 15:26:08 -0500 Received: from fieldses.org ([173.255.197.46]:37712 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726926AbgAUU0I (ORCPT ); Tue, 21 Jan 2020 15:26:08 -0500 Received: by fieldses.org (Postfix, from userid 2815) id B65C71C15; Tue, 21 Jan 2020 15:26:07 -0500 (EST) Date: Tue, 21 Jan 2020 15:26:07 -0500 From: "J. Bruce Fields" To: Alex Shi Cc: Chuck Lever , Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] locked: remove nlmsvc_decode_norep/grantedres Message-ID: <20200121202607.GB25691@fieldses.org> References: <1579595682-251483-1-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1579595682-251483-1-git-send-email-alex.shi@linux.alibaba.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 21, 2020 at 04:34:42PM +0800, Alex Shi wrote: > These 2 macros are never used after first git commit Linux-2.6.12-rc2. > So guess better to remove them. I'm not fond of these macros. If we're going to doing anything to them, I'd rather just get rid of the entirely (including the PROC macro) and write out the initialization of nlmsvc_procedures. Yes, it'd probably add another 80 or so lines to the file, but it'd be readable without referring to the macro definitions. And it would be less confusing to people who grep for the users of the various proc/encode/decode methods and can't find them. --b. > > Signed-off-by: Alex Shi > Cc: "J. Bruce Fields" > Cc: Chuck Lever > Cc: Trond Myklebust > Cc: Anna Schumaker > Cc: linux-nfs@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > fs/lockd/svcproc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/lockd/svcproc.c b/fs/lockd/svcproc.c > index d0bb7a6bf005..8b7565c71863 100644 > --- a/fs/lockd/svcproc.c > +++ b/fs/lockd/svcproc.c > @@ -534,12 +534,10 @@ static __be32 nlmsvc_proc_cancel_msg(struct svc_rqst *rqstp) > */ > > #define nlmsvc_encode_norep nlmsvc_encode_void > -#define nlmsvc_decode_norep nlmsvc_decode_void > #define nlmsvc_decode_testres nlmsvc_decode_void > #define nlmsvc_decode_lockres nlmsvc_decode_void > #define nlmsvc_decode_unlockres nlmsvc_decode_void > #define nlmsvc_decode_cancelres nlmsvc_decode_void > -#define nlmsvc_decode_grantedres nlmsvc_decode_void > > #define nlmsvc_proc_none nlmsvc_proc_null > #define nlmsvc_proc_test_res nlmsvc_proc_null > -- > 1.8.3.1