From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5BB5C2D0CE for ; Fri, 24 Jan 2020 08:26:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B52FA2071A for ; Fri, 24 Jan 2020 08:26:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Enz23/Sh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729828AbgAXI0w (ORCPT ); Fri, 24 Jan 2020 03:26:52 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:52750 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbgAXI0w (ORCPT ); Fri, 24 Jan 2020 03:26:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WVliC4ZkSf65b66McnDSrfnUI5s0aClN3yaQsp8c3S4=; b=Enz23/ShBEd739Cb1q0TjdNPF u31eRjOpLEf7w8QZIDRlG2Ur4GerOlVMkA9pIgPVjB8h2kELbwJepW3EHij5lA+2A6CHIiNO+shVd zrsKDGmZg6fph9V8nQS2WnulL3Zi8EVH5/NQHobxCnp8AE5+WRW1819I69SQef8Wnga3/spq36Kcf payFMU6OCA9KGOpbTHWJHEesURIvXfsR+kWVopijp1dwIklnWXdeZKnbbrIkBwJHkkz7wl8hnHlih 2wE2ya9r/2OEOft7lfRAlqaNm1aaaAiGKm/OxD8zZ/WCqCKshnNP4Z6JRZ+H65XPOoFIFouZLMrBk 3pRkKu6uQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1iuuIa-00017E-9S; Fri, 24 Jan 2020 08:26:40 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 5B2723008A9; Fri, 24 Jan 2020 09:24:57 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id B69B32B713683; Fri, 24 Jan 2020 09:26:37 +0100 (CET) Date: Fri, 24 Jan 2020 09:26:37 +0100 From: Peter Zijlstra To: Nick Desaulniers Cc: Will Deacon , LKML , linux-arch , kernel-team , Michael Ellerman , Linus Torvalds , Segher Boessenkool , Christian Borntraeger , Luc Van Oostenryck , Arnd Bergmann , Peter Oberparleiter , Masahiro Yamada Subject: Re: [PATCH v2 09/10] compiler/gcc: Raise minimum GCC version for kernel builds to 4.8 Message-ID: <20200124082637.GZ14914@hirez.programming.kicks-ass.net> References: <20200123153341.19947-1-will@kernel.org> <20200123153341.19947-10-will@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 23, 2020 at 10:36:37AM -0800, Nick Desaulniers wrote: > On Thu, Jan 23, 2020 at 7:34 AM Will Deacon wrote: > > > > It is very rare to see versions of GCC prior to 4.8 being used to build > > the mainline kernel. These old compilers are also know to have codegen > > issues which can lead to silent miscompilation: > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 > > > > Raise the minimum GCC version for kernel build to 4.8 and remove some > > tautological Kconfig dependencies as a consequence. > > > > Cc: Nick Desaulniers > > Thanks for the patch. > Reviewed-by: Nick Desaulniers > I wouldn't mind if this patch preceded the earlier one in the series > adding the warning, should the series require a v2 and if folks are > generally ok with bumping the min version. If I hadn't actually read your reply, I would have never spotted that reviewed-by tag, hidden in a blob of text like that. Adding some whitespace before and after, such that it stands out a little more, might avoid such issues.