From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F45DC32771 for ; Mon, 27 Jan 2020 10:14:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E9C82087F for ; Mon, 27 Jan 2020 10:14:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729854AbgA0KOr (ORCPT ); Mon, 27 Jan 2020 05:14:47 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:37000 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727409AbgA0KOp (ORCPT ); Mon, 27 Jan 2020 05:14:45 -0500 Received: from localhost (unknown [213.175.37.12]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 86F741512894A; Mon, 27 Jan 2020 02:14:43 -0800 (PST) Date: Mon, 27 Jan 2020 11:14:42 +0100 (CET) Message-Id: <20200127.111442.1993972247561151893.davem@davemloft.net> To: christophe.jaillet@wanadoo.fr Cc: jiri@mellanox.com, idosch@mellanox.com, vadimp@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mlxsw: minimal: Fix an error handling path in 'mlxsw_m_port_create()' From: David Miller In-Reply-To: <20200125211847.12755-1-christophe.jaillet@wanadoo.fr> References: <20200125211847.12755-1-christophe.jaillet@wanadoo.fr> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 27 Jan 2020 02:14:45 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET Date: Sat, 25 Jan 2020 22:18:47 +0100 > An 'alloc_etherdev()' called is not ballanced by a corresponding > 'free_netdev()' call in one error handling path. > > Slighly reorder the error handling code to catch the missed case. > > Fixes: c100e47caa8e ("mlxsw: minimal: Add ethtool support") > Signed-off-by: Christophe JAILLET Applied and queued up for -stable, thanks.