From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90481C33CB7 for ; Mon, 27 Jan 2020 10:55:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 591FC214AF for ; Mon, 27 Jan 2020 10:55:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f3oZhnPu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730127AbgA0Kzj (ORCPT ); Mon, 27 Jan 2020 05:55:39 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:60627 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727964AbgA0Kzj (ORCPT ); Mon, 27 Jan 2020 05:55:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580122538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C5GoHU21tITOeLGcgSeI5DCMeKnGmZHyFA/f49KFvg0=; b=f3oZhnPuzps5Am2LaCzCkb4E3UhI9hSUAYy42buJLvfMh7E+6fSsaAJ+Wl6GHb6rHfGvcW 9AGsiM7Cl0R461B5s2P+BduH+ZM9sJ7I6RjZ3ycAUpoA3VP8A2IqRun+cQwf80z/5WeoXD IkFi5FXt8eFwaVD/kZ0k6RE46+FJy3M= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-N96kRo9eOSWJJRITvih0Fg-1; Mon, 27 Jan 2020 05:55:36 -0500 X-MC-Unique: N96kRo9eOSWJJRITvih0Fg-1 Received: by mail-wm1-f71.google.com with SMTP id f25so1352116wmb.1 for ; Mon, 27 Jan 2020 02:55:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=C5GoHU21tITOeLGcgSeI5DCMeKnGmZHyFA/f49KFvg0=; b=WEgqtaMpL4gBg/SIjlOMqR0pk1viTHbx7VBTtUluZB6f+HC1KOD0j4xEo/91Cc60ON 21LPpcoL2LhhNrOYtPKqbK53OfvDsX0rJpf4vMo4SlDei6KpL9IsAeZBBnTmT2j+E8G1 DhZqRhc9ddjCQgjRs82XZKvGzMEhExdV8g4DLwcCG4hlmt8MpN0xY+CvVD7EGn+T3EOC CyVN0+pgzfGXx5vaLSMKTjFKA/GacD3Y0x8BoQQugi1lx/W66hkrTJpI9xaUyZRjY3od vrzd7WdmQcSC4bJlD0jVPWp1OZCE2S5f0CWHFa1cAre5t9166yCU86n5jL9tRou+14wK pHEg== X-Gm-Message-State: APjAAAUagpfk31YhYRxoRIor5hMpHa9C2iUiBRj8NhCySiZoyCNbd87y Z43/9g9XbUd7BBeKWaQuvNED2/04nAZJYLV0QHJVeV0XN8E9xa9GhUkvepn6Twdf9/qpykU5Ecx 2OLco1ynO3cOHYP6g2UXD2lA= X-Received: by 2002:adf:e58d:: with SMTP id l13mr21065277wrm.135.1580122535314; Mon, 27 Jan 2020 02:55:35 -0800 (PST) X-Google-Smtp-Source: APXvYqxmXHDECwNyV4sc/J2dESQugTCA1QujhGGSTGYrOTm4ABN+g+mCYs8AGc58vXWnshCbjImijQ== X-Received: by 2002:adf:e58d:: with SMTP id l13mr21065242wrm.135.1580122535083; Mon, 27 Jan 2020 02:55:35 -0800 (PST) Received: from localhost (cpc111743-lutn13-2-0-cust844.9-3.cable.virginm.net. [82.17.115.77]) by smtp.gmail.com with ESMTPSA id x14sm18076625wmj.42.2020.01.27.02.55.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jan 2020 02:55:34 -0800 (PST) Date: Mon, 27 Jan 2020 10:55:33 +0000 From: Aaron Tomlin To: Tetsuo Handa Cc: Grzegorz Halat , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, ssaner@redhat.com, oleksandr@redhat.com, vbendel@redhat.com, kirill@shutemov.name, khlebnikov@yandex-team.ru, borntraeger@de.ibm.com, Andrew Morton , Iurii Zaikin , Kees Cook , Luis Chamberlain , Jonathan Corbet Subject: Re: [PATCH 1/1] mm: sysctl: add panic_on_mm_error sysctl Message-ID: <20200127105533.azrlz2ff73vrhg6n@atomlin.usersys.com> References: <20200127101100.92588-1-ghalat@redhat.com> <063e702f-dc5f-b0ca-fe26-508a9f1e8e9a@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <063e702f-dc5f-b0ca-fe26-508a9f1e8e9a@I-love.SAKURA.ne.jp> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 User-Agent: NeoMutt/20180716-1637-ee8449 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2020-01-27 19:42 +0900, Tetsuo Handa wrote: > On 2020/01/27 19:11, Grzegorz Halat wrote: > > diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst > > index def074807cee..2fecd6b2547e 100644 > > --- a/Documentation/admin-guide/sysctl/kernel.rst > > +++ b/Documentation/admin-guide/sysctl/kernel.rst > > @@ -61,6 +61,7 @@ show up in /proc/sys/kernel: > > - overflowgid > > - overflowuid > > - panic > > +- panic_on_mm_error > > Maybe panic_on_inconsistent_mm is better, for an MM error sounds too generic > (e.g. is page allocation failure an error, is OOM killer an error, > is NULL pointer dereference an error, is use-after-free access an error) ? Fair enough; 'panic_on_inconsistent_mm' is more concise. -- Aaron Tomlin