From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7CBCC33CB7 for ; Mon, 27 Jan 2020 21:26:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85C4C2465B for ; Mon, 27 Jan 2020 21:26:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726303AbgA0V0o (ORCPT ); Mon, 27 Jan 2020 16:26:44 -0500 Received: from ms.lwn.net ([45.79.88.28]:36098 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbgA0V0n (ORCPT ); Mon, 27 Jan 2020 16:26:43 -0500 Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id BF0ED7DF; Mon, 27 Jan 2020 21:26:42 +0000 (UTC) Date: Mon, 27 Jan 2020 14:26:41 -0700 From: Jonathan Corbet To: Geert Uytterhoeven Cc: Mauro Carvalho Chehab , Jani Nikula , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scripts/find-unused-docs: Fix massive false positives Message-ID: <20200127142641.6e865467@lwn.net> In-Reply-To: <20200127093107.26401-1-geert+renesas@glider.be> References: <20200127093107.26401-1-geert+renesas@glider.be> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Jan 2020 10:31:07 +0100 Geert Uytterhoeven wrote: > scripts/find-unused-docs.sh invokes scripts/kernel-doc to find out if a > source file contains kerneldoc or not. > > However, as it passes the no longer supported "-text" option to > scripts/kernel-doc, the latter prints out its help text, causing all > files to be considered containing kerneldoc. > > Get rid of these false positives by removing the no longer supported > "-text" option from the scripts/kernel-doc invocation. > > Fixes: b05142675310d2ac ("scripts: kernel-doc: get rid of unused output formats") > Signed-off-by: Geert Uytterhoeven Sigh, I guess I should have tried that script before telling people to use it. Thanks for the fix; I've applied it with a CC: stable tag. jon