From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A488AC33CB7 for ; Wed, 29 Jan 2020 17:53:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 806AC20716 for ; Wed, 29 Jan 2020 17:53:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727427AbgA2RxB (ORCPT ); Wed, 29 Jan 2020 12:53:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:33528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727386AbgA2Rw5 (ORCPT ); Wed, 29 Jan 2020 12:52:57 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B08BB20716; Wed, 29 Jan 2020 17:52:56 +0000 (UTC) Date: Wed, 29 Jan 2020 12:52:55 -0500 From: Steven Rostedt To: Tom Zanussi Cc: artem.bityutskiy@linux.intel.com, mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, ndesaulniers@google.com Subject: Re: [PATCH v3 02/12] tracing: Add trace_get/put_event_file() Message-ID: <20200129125255.57159f85@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Jan 2020 16:56:13 -0600 Tom Zanussi wrote: > +/** > + * trace_put_event_file - Release a file from trace_get_event_file() > + * @file: The trace event file > + * > + * If a file was retrieved using trace_get_event_file(), this should > + * be called when it's no longer needed. It will cancel the previous > + * trace_array_get() called by that function, and decrement the > + * event's module refcount. > + */ > +void trace_put_event_file(struct trace_event_file *file) > +{ > + trace_array_put(file->tr); > + > + mutex_lock(&event_mutex); > + module_put(file->event_call->mod); > + mutex_unlock(&event_mutex); I believe the trace_array_put() needs to be at the end. Otherwise, I believe the file could be freed before the event_mutex is taken. I'll swap it, as I'm trying to get this into the merge window. -- Steve > +} > +EXPORT_SYMBOL_GPL(trace_put_event_file); > + > #ifdef CONFIG_DYNAMIC_FTRACE > > /* Avoid typos */