From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D30A3C2D0DB for ; Wed, 29 Jan 2020 13:25:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B04D520732 for ; Wed, 29 Jan 2020 13:25:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726671AbgA2NZt (ORCPT ); Wed, 29 Jan 2020 08:25:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:53220 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbgA2NZs (ORCPT ); Wed, 29 Jan 2020 08:25:48 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A5101AC46; Wed, 29 Jan 2020 13:25:46 +0000 (UTC) Date: Wed, 29 Jan 2020 14:25:41 +0100 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Christian Brauner Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo , Oleg Nesterov , Li Zefan , Johannes Weiner , cgroups@vger.kernel.org Subject: Re: [PATCH v5 1/6] cgroup: unify attach permission checking Message-ID: <20200129132540.GA11384@blackbody.suse.cz> References: <20200121154844.411-1-christian.brauner@ubuntu.com> <20200121154844.411-2-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200121154844.411-2-christian.brauner@ubuntu.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 21, 2020 at 04:48:39PM +0100, Christian Brauner wrote: > +static int cgroup_attach_permissions(struct cgroup *src_cgrp, > + struct cgroup *dst_cgrp, > + struct super_block *sb, bool thread) I suggest inverting the logic of the last argument to make it consistent with other functions that use threadgroup argument for similar distinction. Apart from that Acked-by: Michal Koutný