From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EFFEC35240 for ; Wed, 29 Jan 2020 17:29:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2EEC42070E for ; Wed, 29 Jan 2020 17:29:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="q0VBHX6g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727244AbgA2R3r (ORCPT ); Wed, 29 Jan 2020 12:29:47 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:53848 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726679AbgA2R3r (ORCPT ); Wed, 29 Jan 2020 12:29:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=go3PPhlFlFB8RCk4Btk/36NAr12d6OBh6WpwQRFkuoc=; b=q0VBHX6gDEX+2GikgiRVZHs/V eBc1fpa6EF2NuB1E7pIZl//mk9MqK+ILSdNEXEJOYsiyxxVDbTibb4UCtiZGkB2CBmujvi/sJ5x9y tWXg1hM8DS3FVOJK6L6fPBuqjpFKw+DZONIWbyJUV8Y2xNKKYPYMNAZtY/hQvg0gFuF8d075+igot OsWz+Cw2TUUMh8jfPF8+ne2m87uDyniS+wawOTb9kLQ4lxgdTtLNHAx/gPtFFsr0YZPMXw8HisPEA rmrot+VCudv5pP6lyCCDkn4sUvOHnJzwdN+/g/RUfRkK+3GrCPepeRBHQpc0bh/3wsb2YeOHIia6d mdIUaS/Ag==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iwr9s-0000YV-MJ; Wed, 29 Jan 2020 17:29:44 +0000 Date: Wed, 29 Jan 2020 09:29:44 -0800 From: Christoph Hellwig To: Bartlomiej Zolnierkiewicz Cc: Jens Axboe , Michael Schmitz , Geert Uytterhoeven , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/28] ata: move ata_dev_config_ncq*() to libata-core-sata.c Message-ID: <20200129172944.GJ12616@infradead.org> References: <20200128133343.29905-1-b.zolnierkie@samsung.com> <20200128133343.29905-15-b.zolnierkie@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200128133343.29905-15-b.zolnierkie@samsung.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 28, 2020 at 02:33:29PM +0100, Bartlomiej Zolnierkiewicz wrote: > * move ata_log_supported() to libata.h and make it inline > > * move ata_dev_config_ncq*() to libata-core-sata.c > > * add static inline version of ata_dev_config_ncq() for > CONFIG_SATA_HOST=n case Wouldn't it be easier to throw in an IS_ENABLED() into the ATA_FLAG_FPDMA_AUX before calling ata_dev_config_ncq_* and let the compiler optimize out the functions?