From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A0CC35240 for ; Wed, 29 Jan 2020 17:30:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22EB92070E for ; Wed, 29 Jan 2020 17:30:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Ylpz4k/w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727318AbgA2Rat (ORCPT ); Wed, 29 Jan 2020 12:30:49 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:53902 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726679AbgA2Rat (ORCPT ); Wed, 29 Jan 2020 12:30:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=o+SfkqM7IwL8WIyIL0CKEGXCT3IYNXMJqubtS71yKOU=; b=Ylpz4k/wIU3Z71JJsr3QC/xXI W/vUYg+5VUig4ujgOriKJ3nM5g1O6FYia51jeMeeteqmgvKXSxCB9gCmWYnZz65N9Mz6cTFbGd0yJ s6fcjCIAlWCV1g3ZYU1elHYmUoKWO2YWVMFPwss4/56JFErTxgW78gDYSdPLG9CKlnvhvmthdrLCX CmcoZQdmeNsbiwT6lIT9uQRQB7hW6kSqwm4z3gtMkahWnIgUstMxLWF6CuvqequowTor9i6yO9JT/ 9ec1CH3QCQWTsrwI4aPk0Mhi6ePjiabDOoUxsmH/ErmyeD/71nYVh+jWyhS9MOwc8hZ5T/bb2IpwD lIFe+XvbA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iwrAr-0001zx-Nu; Wed, 29 Jan 2020 17:30:45 +0000 Date: Wed, 29 Jan 2020 09:30:45 -0800 From: Christoph Hellwig To: Bartlomiej Zolnierkiewicz Cc: Jens Axboe , Michael Schmitz , Geert Uytterhoeven , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/28] ata: move sata_print_link_status() to libata-core-sata.c Message-ID: <20200129173045.GK12616@infradead.org> References: <20200128133343.29905-1-b.zolnierkie@samsung.com> <20200128133343.29905-16-b.zolnierkie@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200128133343.29905-16-b.zolnierkie@samsung.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 28, 2020 at 02:33:30PM +0100, Bartlomiej Zolnierkiewicz wrote: > * move sata_print_link_status() to libata-core-sata.c > > * add static inline for CONFIG_SATA_HOST=n case With the IS_ENABLED() in sata_scr_read the compile should be able to just do this by itself - maybe with an inline thrown in for sata_print_link_status if the compiler behaves stupidly.