From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AACEBC2D0DB for ; Thu, 30 Jan 2020 15:33:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B5A420707 for ; Thu, 30 Jan 2020 15:33:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727191AbgA3Pd3 (ORCPT ); Thu, 30 Jan 2020 10:33:29 -0500 Received: from mga06.intel.com ([134.134.136.31]:47862 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727186AbgA3PdZ (ORCPT ); Thu, 30 Jan 2020 10:33:25 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2020 07:26:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,382,1574150400"; d="scan'208";a="218308625" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga007.jf.intel.com with ESMTP; 30 Jan 2020 07:26:00 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 4A0D119C; Thu, 30 Jan 2020 17:25:59 +0200 (EET) From: Andy Shevchenko To: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v4 1/6] console: Don't perform test for CON_BRL flag Date: Thu, 30 Jan 2020 17:25:53 +0200 Message-Id: <20200130152558.51839-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't call braille_register_console() without CON_BRL flag set. And the _braille_unregister_console() already tests for console to have CON_BRL flag. No need to repeat this in braille_unregister_console(). Drop the repetitive checks from Braille console driver. Signed-off-by: Andy Shevchenko Reviewed-by: Petr Mladek --- v4: Add tag (Petr) drivers/accessibility/braille/braille_console.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/accessibility/braille/braille_console.c b/drivers/accessibility/braille/braille_console.c index 1339c586bf64..a8f7c278b691 100644 --- a/drivers/accessibility/braille/braille_console.c +++ b/drivers/accessibility/braille/braille_console.c @@ -347,8 +347,6 @@ int braille_register_console(struct console *console, int index, { int ret; - if (!(console->flags & CON_BRL)) - return 0; if (!console_options) /* Only support VisioBraille for now */ console_options = "57600o8"; @@ -371,8 +369,6 @@ int braille_unregister_console(struct console *console) { if (braille_co != console) return -EINVAL; - if (!(console->flags & CON_BRL)) - return 0; unregister_keyboard_notifier(&keyboard_notifier_block); unregister_vt_notifier(&vt_notifier_block); braille_co = NULL; -- 2.24.1