From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 824D5C2D0DB for ; Fri, 31 Jan 2020 15:58:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 557F12082E for ; Fri, 31 Jan 2020 15:58:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580486319; bh=hnLIGrf0deqBJjaJ6PHTwO5DN5zv5O1TDu/IlTX85uk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=LoCSugnxwABcBqWxDC0CQfRAMPIbHXlSAX9W0TcGHvqpKAW7M9ygD41wlWxDyQGwo AE8F1ZXgaDgVVFiUnUbpexXGOsugoVFrAYdJzURa3YYrtQtdVh5PZh0L3MBgE9pDKF oLwFx3wMZ2MoN6KwRTJeoaq8R+uKDpY2wyuynYws= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729282AbgAaP6i (ORCPT ); Fri, 31 Jan 2020 10:58:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:50770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728846AbgAaP6i (ORCPT ); Fri, 31 Jan 2020 10:58:38 -0500 Received: from cakuba.hsd1.ca.comcast.net (unknown [199.201.64.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 43E8F206D3; Fri, 31 Jan 2020 15:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580486317; bh=hnLIGrf0deqBJjaJ6PHTwO5DN5zv5O1TDu/IlTX85uk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wNYK7EnNFsJUWWYopW9YsU3Xmp+EYNDveunBLuK0DZ3O3smo3i5P9Hy62DZtPCUK4 zcZ2/eL2RT0BHRhGUl1oY1Osr1VN6AMwvD4JjGeR2PWXNOdq+zGu0wdxC/bDrwj0ZF JXWW58C1ebe4OGI3g9fOhCe471k6L8dihTiJ1Ik8= Date: Fri, 31 Jan 2020 07:58:36 -0800 From: Jakub Kicinski To: Michael Walle Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "David S . Miller" , Russell King , Heiner Kallweit , Florian Fainelli , Andrew Lunn Subject: Re: [PATCH net-next] net: phy: at803x: disable vddio regulator Message-ID: <20200131075836.485d5583@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20200130175402.19567-1-michael@walle.cc> References: <20200130175402.19567-1-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Jan 2020 18:54:02 +0100, Michael Walle wrote: > The probe() might enable a VDDIO regulator, which needs to be disabled > again before calling regulator_put(). Add a remove() function. > > Fixes: 2f664823a470 ("net: phy: at803x: add device tree binding") > Signed-off-by: Michael Walle Applied, thank you!