From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67EFEC3F68F for ; Fri, 31 Jan 2020 14:27:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3FC922067C for ; Fri, 31 Jan 2020 14:27:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="zym66xsy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729030AbgAaO1z (ORCPT ); Fri, 31 Jan 2020 09:27:55 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:42201 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728988AbgAaO1z (ORCPT ); Fri, 31 Jan 2020 09:27:55 -0500 Received: by mail-wr1-f67.google.com with SMTP id k11so8808749wrd.9 for ; Fri, 31 Jan 2020 06:27:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=V/PCnqNtDQJTE0n6z019lCU8yqKmiVuTIJCF6Mgs2hA=; b=zym66xsy/sjzCBn080zU+FiBL1C3WjHGj6hPdfx+yz4tx+sXjgCI4IXwOcP9KNvUr8 6xFC8DlHxEY9TDbv71iMStIek4j0ibL8+k1x0uloTJlEcofseH+Me4fZK0nY0uaJ1l2B MhgiEy4L3KgUMEJ2vBNwdDr2F/Qc2pQES4V0TnYIZSxkhpL+J7pIIzSZxpwibXe7atfi m4J0ZN45z+vzoF2Sh8E5EdsKIJMNMACaoDn/Vv+PsEBgXOEYSs6XQeFQgj3Vu9JYN9rP jEeTloINK+LpNlSfYB9wbzt3pgjTwCG+J1xn3oNJviWGRq5jOdoCf4iUO1imiX3vMGFS r6NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=V/PCnqNtDQJTE0n6z019lCU8yqKmiVuTIJCF6Mgs2hA=; b=leumneRNySWoh+KkY4zc8GtZLQXzkemW9NvAAWv605TTdqNdi5u811hECZSn29ofNp UAAwhyCU6WkKOXgghWIG/+kvuRSmCBJN1O82xUuQLOZxW2noFLoBosRkcT6xb07TuP1O IQ92bfGjJVckPqtMtnn1g9iqPouOSjQBUEhoUx/H+W4XfCdXQFH3mDfgULAdB2MZoqG9 Irq6pTqfPtdTij5jY+hb3SnxHhRvw6e2psiaoQkK6N62Rwma7ImKBrFcvI8P9GDqugon MJEY+PgOQSKVV4rCoOLPJel7XIglL6GSH12XT2poaXBJ+WCzzL61aGtfqaO25SBxLlXu x53Q== X-Gm-Message-State: APjAAAWpkKbnpHspLLdfuWvpr5CIQDhv44Sm/taqkW7H/3anMTDchBVb 4x7gAZsePArNhEDU40odD130DQ== X-Google-Smtp-Source: APXvYqwffjVdonyWBGQTjTsoah1oQOI+zi0erFyjvn3dkdCOYmw51m6xt5K4qjQP30gxfi9r574VWA== X-Received: by 2002:a5d:4651:: with SMTP id j17mr12699429wrs.237.1580480871833; Fri, 31 Jan 2020 06:27:51 -0800 (PST) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id j12sm12916560wrw.54.2020.01.31.06.27.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2020 06:27:51 -0800 (PST) Date: Fri, 31 Jan 2020 15:27:50 +0100 From: Jiri Pirko To: Nathan Chancellor Cc: Jiri Pirko , Ido Schimmel , "David S. Miller" , Petr Machata , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Randy Dunlap Subject: Re: [PATCH v2] mlxsw: spectrum_qdisc: Fix 64-bit division error in mlxsw_sp_qdisc_tbf_rate_kbps Message-ID: <20200131142750.GA2251@nanopsycho.orion> References: <20200130232641.51095-1-natechancellor@gmail.com> <20200131015123.55400-1-natechancellor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200131015123.55400-1-natechancellor@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fri, Jan 31, 2020 at 02:51:23AM CET, natechancellor@gmail.com wrote: >When building arm32 allmodconfig: > >ERROR: "__aeabi_uldivmod" >[drivers/net/ethernet/mellanox/mlxsw/mlxsw_spectrum.ko] undefined! > >rate_bytes_ps has type u64, we need to use a 64-bit division helper to >avoid a build error. > >Fixes: a44f58c41bfb ("mlxsw: spectrum_qdisc: Support offloading of TBF Qdisc") >Signed-off-by: Nathan Chancellor Acked-by: Jiri Pirko